Add opt-in structured review result to local review (#69) - #527
Merged
Merged
Conversation
local-code-review can now append one schema-versioned machine-readable JSON result after its unchanged human report when the invocation sets structured_review_result (default off). A packaged policy owns the serialization and finding-identity minting; a drift test pins it to the #67 schema and the identity reference model. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…uctured-output # Conflicts: # docs/review-result/README.md # docs/review-result/review-result-model.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in machine-readable result to
local-code-review; contract and semantics live inshared/policies/structured-output.mdanddocs/review-result/.Fixes #69
What
structured_review_result(default off). When set, one schema-versioned JSON result (withschema_versionand reviewed head SHA) is appended after the unchanged human report. Findings, severity, coverage and the mechanical Decision are identical on and off.reviewed_head_shaisnullwhen the reviewed target includes uncommitted changes.structured-outputcapability; the packaged policy also carries the finding-identity minting recipe (SHA-256 computed by shell, never written by hand). A drift test pins it to the Define review output schema #67 schema and identity reference model; the option name is protected from being read ashuman_review_output'sstructured reviewnegative phrase.local,github; only local wires it). Manifest and skill metadata regenerated; local baseline hashes re-captured.CHANGELOG.md(seedocs/RELEASE.md)local-code-reviewcan append an opt-in, schema-versioned machine-readable review result viastructured_review_result.Validation
package-skills.sh allpass. Last full run had a live-model benchmark test (test_blocking_verdict_corpusreal-run) failing on a different case each run; not confirmed againstmain. Full suite not re-run after the final fixes.Review
Merged
main(incl. #70 GitHub structured output); resolved conflicts indocs/review-result/README.mdandreview-result-model.mdto describe both Skills' emission. The twostructured-output.mdpolicies (shared/ for local,skills/github-pr-review/policies/) are separate files.local-code-reviewon the working tree: Review Clean after fixing one P1 (option-name phrase collision) and one P2 (example added); one P2 open —reviewed_head_shaisnullfor uncommitted targets, maintainer to confirm.🤖 Generated with Claude Code