Manifest v3 - Mostly works#438
Open
Jupiter-Liar wants to merge 2 commits intoamitbl:masterfrom
Open
Conversation
|
im hoping for the best you been a life saver I use it on my dads PC cuz he thinks politics is a requirement and it ain't good for his stress issues so I wish u the best and have a great year |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This V3 port mostly works when I test it. There is one place where the original seed.js was causing the script not to work. It was the "if (window.writeEmbed || window.ytplayer || window.Polymer)" check. The script wouldn't work at all with that in place. The error message and return were always triggered. I wasn't really sure how to fix this, so I tried adding a mutation observer. It lets the script work, instead of just returning, but it also allows the error that this check was supposed to prevent.
I'm not really sure how to fix this part properly. You'll have to figure that part out. But in the meantime, this gets the extension most of the way to a proper V3 version, since V2 support is ending. It's V3. It runs. It just has some kinks to work out.
I just tested basic blocking. I didn't test advanced blocking.