Feature Update: Unit Tests, Ticket Sorting, View Template Addons, Fault Tolerant Commands#54
Open
Auwate wants to merge 53 commits intoamlight:masterfrom
Open
Feature Update: Unit Tests, Ticket Sorting, View Template Addons, Fault Tolerant Commands#54Auwate wants to merge 53 commits intoamlight:masterfrom
Auwate wants to merge 53 commits intoamlight:masterfrom
Conversation
COMMENTED OUT LOGGING DRIVER
Latest Update now has a time associated with it.
ADDED CLASS TO DIV ON LINE 209. ADDED CSS PROPERTIES TO .row
Unit Tests and a new file: settings-test.py
Includes: - settings-dev.py - Delete migrations - Changing templates and forms to only say UTC - test-models.py
…ur when latest_action_notes is checked. This could cause an error because not all Tickets have logs, and if a Ticket without a log is called, it could raise an error.
Align with master repo.
Align with master repo
Align with master repo
Align with master repo
Align with master repo
Align with master repo
Align with master repo
italovalcy
requested changes
Apr 9, 2024
Member
italovalcy
left a comment
italovalcy
left a comment
There was a problem hiding this comment.
Austin, excellent pull request and all changes make sense for me. I just left one comment regarding the GitHub repo used for Dockerfile. Please let me know if you have more information on that.
deploy/Dockerfile
Outdated
| WORKDIR /opt | ||
|
|
||
| RUN git clone https://github.com/amlight/Services-Status.git | ||
| RUN git clone https://github.com/Auwate/Services-Status.git |
Member
There was a problem hiding this comment.
Hi Austin, this particular change here does not seems necessary. Can you please clarify why we need this?
Author
There was a problem hiding this comment.
Ah I was testing using my forked repo, I'll fix that right now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a full description, please check the README.md file under recent changes.