Skip to content

fix: adding currency property to events #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
izaaz merged 4 commits into from
Feb 26, 2025
Merged

fix: adding currency property to events #60

izaaz merged 4 commits into from
Feb 26, 2025

Conversation

@izaaz
Copy link
Contributor

@izaaz izaaz commented Feb 26, 2025 •
edited
Loading

Summary

  • Adding currency property to our events
  • I noticed that exceptions in callbacks weren't causing the test to fail. So fixing that as well.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

Mercy811
Mercy811 approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@Mercy811 Mercy811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @izaaz. Are you adding currency to all sdks?

@izaaz
Copy link
Contributor Author

izaaz commented Feb 26, 2025

Thanks @izaaz. Are you adding currency to all sdks?

Yes, i'll be adding to all our SDKs

@izaaz izaaz merged commit 6984e76 into main Feb 26, 2025
9 checks passed
@izaaz izaaz deleted the AMP-124896/add_currency_property branch February 26, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mercy811 Mercy811 Mercy811 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@izaaz @Mercy811