Highlight AMP-compatible themes and plugins in admin by dhaval-parekh · Pull Request #6597 · ampproject/amp-wp

dhaval-parekh · 2021-09-08T18:01:21Z

Summary

Fixes #2313

AMP-GH-Issue-2313.mov

Checklist

My code is tested and passes existing tests.
My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

github-actions · 2021-09-08T18:06:12Z

Plugin builds for 49b37fa are ready 🛎️!

Download development build
Download production build

lgtm-com · 2021-09-09T13:26:04Z

This pull request introduces 1 alert when merging 0cc9223 into 3f0146e - view on LGTM.com

new alerts:

1 for Useless assignment to local variable

jwold · 2021-09-09T17:50:49Z

@dhaval-parekh I ran into an issue trying to test this. Just to clarify, does this also work when searching plugins and themes?

lgtm-com · 2021-09-10T09:09:04Z

This pull request introduces 1 alert when merging 2df393c into deba08a - view on LGTM.com

new alerts:

1 for Useless assignment to local variable

lgtm-com · 2021-09-10T16:55:00Z

This pull request introduces 1 alert when merging af2799a into f819294 - view on LGTM.com

new alerts:

1 for Useless assignment to local variable

dhaval-parekh · 2021-09-30T13:43:05Z

@dhaval-parekh I ran into an issue trying to test this. Just to clarify, does this also work when searching plugins and themes?

@jwold I think previously it was a bug and not showing. PX message after serach. But it's fixed now.

… list

westonruter · 2021-11-02T22:58:44Z

Regarding #6597 (comment):

WordPress uses 1000 ms as debounce wait time on keyup input event of the input search box. Within that function is store jQuery promise of AJAX request int wp.update.searchRequest global variable.

To ensure global variable wp.update.searchRequest our callback has to run after WordPress's callback, 1500ms is used as wait time in our callback.

Reference

OK, I think I see. So the debouncing must be at least 1001 milliseconds because before that there is no guarantee that wp.update.searchRequest will be defined. However, as soon as the request completes the wp.update.searchRequest variable is deleted bt core (unfortunately), so that means if the Ajax request completes in faster than 500ms, the 1500ms delay will run too late and wp.update.searchRequest will have been deleted. On my local system, the Ajax plugin search request takes ~800ms, so it works for me. However, on the dev environment for amp-wp.org the request returns in ~400ms, so this would fail to inject in that case (as 1000ms + 400ms < 1500ms).

I think what may be required is to use MutationObserver here instead for more reliability. I'll try.

westonruter · 2021-11-03T00:31:04Z

+	 * Override theme view.
+	 */
+	overrideViews() {
+		wp.themes.view.Theme = ampViewTheme;


Something we may need to look out for here: what if another plugin is also doing a similar thing? Will their overrides get lost? I suppose not if they are also extending wp.themes.view.Theme because if they do so then they would be extending our extension, or vice-versa. Still, something to look out for.

westonruter · 2021-11-03T04:02:47Z

+				$response->themes[ $i ] = (object) $theme;
+			}
+		} else {
+			$response->themes = $themes;


This doesn't seem to ever be called.

Yes, We can remove that. But need to make sure the function only serve when $action is 'query_themes'.
I have updated it in the new PR #6681

westonruter · 2021-11-03T04:03:49Z

+	 */
+	public function filter_plugins_table_api_args() {
+
+		$per_page   = 100; // @todo There are currently 56 plugins, so this will show all. This is done because pagination is not working.


@dhaval-parekh Please look into pagination of the AMP-compatible plugins list in another PR.

Please have a look at this PR #6681
I have addressed the pagination issue in this PR.

dhaval-parekh requested review from delawski and pierlon as code owners September 8, 2021 18:01

westonruter reviewed Sep 9, 2021

View reviewed changes

Comment thread includes/embeds/class-amp-twitter-embed-handler.php Outdated

dhaval-parekh self-assigned this Sep 10, 2021

westonruter added this to the v2.2 milestone Sep 10, 2021

dhaval-parekh changed the title ~~Enhancement/2313 highlight amp compatible theme plugin~~ Highlight amp compatible theme plugin Sep 10, 2021

dhaval-parekh added 18 commits October 1, 2021 14:25

Add skeleton for new tab in plugin install screen

1e8de3b

Add skeleton for new tab in theme install screen

34ae487

Add script for generate json file for plugins and themes

dda5938

update script for plugin and theme json data

5deff42

Update json file for plugin

68b73ac

Add basic markup for AMP tab in plugin install screen

1dc1f8d

Change the content of amp tab in install plugin page

19f3e15

Add AMP icon in PX Enhancing tab

c1ed08c

Add PX enahacing tab in theme install screen

0afc726

Add PX enahacing tab in theme install screen

f7cc67d

Add New tab in theme install page for PX enhanced themes

5cc29a6

Add tooltip in AMP compatible message in install plugin/theme page

dac1640

Add AMP compatiable message in plugin card on install plugin page

efd0253

Add plugin meta for AMP compatibility in plugin listing page

31f36ff

Add AMP compatiable message for compatiable themes in installed theme…

e235fe2

… list

Remove rating info for none wporg plugins

89514c7

Rename the class names

b088689

Add unit test cases

d5e095e

westonruter added 3 commits November 2, 2021 15:07

Account for plugins and themes variables always being arrays

03171f8

Sort themes and plugins alphabetically

08743c6

Add includes/ecosystem-data to PHP exclusion list

16735e3

westonruter added 6 commits November 2, 2021 16:30

Utilize MutationObserver to watch for card updates

6e552c1

Only run code for plugin search results setup once

15e6199

Improve placement of isAmpCompatibleTab conditionals

25b83eb

Simplify logic considering once events

c64ff0e

Remove extraneous spaces and improve child manipulation

7a8487f

Prevent showing AMP badge icon on AMP Compatible themes tab

46db0a2

westonruter reviewed Nov 3, 2021

View reviewed changes

westonruter added 11 commits November 2, 2021 17:47

Remove fs and child_process packages since built-in to Node

f47398b

Regenerate ecosystem data

760ae35

Prevent adding assets needlessly to plugin list table

53a85b7

Fix AmpPlugin::register test and remove unused is_file_exists vars

9cfc78c

Try fixing AmpThemesTest::test_is_needed

46fc670

Define 'amp-compatible' in constants

0981169

Fix import order

326b603

Add noopener and noreferrer to ecosystem links

496a134

Show all AMP-compatible plugins since pagination is not working

83c6d3c

Improve method names in AmpPlugins

b7f8e6e

Improve methods in AmpThemes

7ee0295

westonruter reviewed Nov 3, 2021

View reviewed changes

Use more int casting

49b37fa

westonruter approved these changes Nov 3, 2021

View reviewed changes

westonruter merged commit c50cb9f into develop Nov 3, 2021

westonruter deleted the enhancement/2313-highlight-amp-compatible-theme-plugin branch November 3, 2021 04:22

dhaval-parekh mentioned this pull request Nov 3, 2021

Fix pagination in AMP-compatible tab of plugins list page. #6681

Merged

2 tasks

westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Highlight AMP-compatible themes and plugins in admin#6597

Highlight AMP-compatible themes and plugins in admin#6597
westonruter merged 110 commits into
developfrom
enhancement/2313-highlight-amp-compatible-theme-plugin

dhaval-parekh commented Sep 8, 2021

Uh oh!

github-actions Bot commented Sep 8, 2021 •

edited

Loading

Uh oh!

lgtm-com Bot commented Sep 9, 2021

Uh oh!

jwold commented Sep 9, 2021

Uh oh!

Uh oh!

lgtm-com Bot commented Sep 10, 2021

Uh oh!

lgtm-com Bot commented Sep 10, 2021

Uh oh!

dhaval-parekh commented Sep 30, 2021

Uh oh!

westonruter commented Nov 2, 2021

Uh oh!

westonruter Nov 3, 2021

Uh oh!

westonruter Nov 3, 2021

Uh oh!

dhaval-parekh Nov 3, 2021

Uh oh!

westonruter Nov 3, 2021

Uh oh!

dhaval-parekh Nov 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

dhaval-parekh commented Sep 8, 2021

Summary

Checklist

Uh oh!

github-actions Bot commented Sep 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtm-com Bot commented Sep 9, 2021

Uh oh!

jwold commented Sep 9, 2021

Uh oh!

Uh oh!

lgtm-com Bot commented Sep 10, 2021

Uh oh!

lgtm-com Bot commented Sep 10, 2021

Uh oh!

dhaval-parekh commented Sep 30, 2021

Uh oh!

westonruter commented Nov 2, 2021

Uh oh!

westonruter Nov 3, 2021

Choose a reason for hiding this comment

Uh oh!

westonruter Nov 3, 2021

Choose a reason for hiding this comment

Uh oh!

dhaval-parekh Nov 3, 2021

Choose a reason for hiding this comment

Uh oh!

westonruter Nov 3, 2021

Choose a reason for hiding this comment

Uh oh!

dhaval-parekh Nov 3, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Sep 8, 2021 •

edited

Loading