Include test particle calculations in Ph4#1161
Merged
rieder merged 3 commits intoamusecode:mainfrom Jul 24, 2025
ErwanH29:main
Merged
Include test particle calculations in Ph4#1161rieder merged 3 commits intoamusecode:mainfrom ErwanH29:main
rieder merged 3 commits intoamusecode:mainfrom
ErwanH29:main
Conversation
Contributor
|
Looks good. |
rieder
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a couple of lines in Ph4 to allow for test particle computations. Stopping conditions neglect collisions between test particles.
I closed the previous iteration to do a hard reset on my local repository, given the new AMUSE release.
The modified scripts (interface.cc and src/idata.cc) are no different to the previous pull request.