Skip to content

[19.0][MIG] l10n_mx_edi_addenda_kuehne_nagel: Migration to 19.0 - #62

Merged
max3903 merged 4 commits into
amxodoo:19.0from
ursais:19.0-mig-l10n_mx_edi_kuehne_nagel
Aug 27, 2026
Merged

max3903 merged 4 commits into
amxodoo:19.0from
ursais:19.0-mig-l10n_mx_edi_kuehne_nagel

Conversation

@hector-fe-dev

@hector-fe-dev hector-fe-dev commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Port l10n_mx_edi_addenda_kuehne_nagel to Odoo 19 as an l10n_mx_edi.addenda record (no longer ir.ui.view).
  • Keep the KNRECEPCION invoice fields and the addenda tab (invisible="not kn_flag"), including the hidden kn_flag field so the tab still shows.
  • Restore QWeb coverage: render the addenda arch and assert KNRECEPCION, Purchase_Order, FileNumber_GL, Branch_Centre, and TransportRef for empty and filled values.

Notes

  • kn_file_type is still unused in the QWeb, and the addenda still uses http://www.w3.org/2001/XMLSchema. Both are pre-existing on 17.0 and were left as-is.
  • Other addendas and the root README addons table are unchanged.

Test plan

  • Install l10n_mx_edi_addenda_kuehne_nagel on a MX company.
  • Assign Addenda Kuehne Nagel on a customer and confirm the Kuehne+Nagel Addenda tab appears on the invoice.
  • Confirm the tab stays hidden for a partner without that addenda.
  • Fill Customer Reference, file/tracking number, branch, and transport ref; stamp a CFDI and check the KNRECEPCION nodes.
  • Leave those fields empty and confirm the same nodes are present but empty.
  • Run l10n_mx_edi_addenda_kuehne_nagel tests.

Dependencies

  • account — already on 19.0
  • l10n_mx_edi — already on 19.0 (Odoo Enterprise Mexican EDI)

@hector-fe-dev
hector-fe-dev marked this pull request as draft August 19, 2026 23:52
@hector-fe-dev
hector-fe-dev marked this pull request as ready for review August 19, 2026 23:52
@max3903 max3903 added this to the 19.0 milestone Aug 20, 2026
@max3903 max3903 added migration needs review Needs review series:19.0 Odoo 19.0 mod:l10n_mx_edi_addenda_kuehne_nagel l10n_mx_edi_addenda_kuehne_nagel labels Aug 20, 2026
@max3903 max3903 self-assigned this Aug 20, 2026
@max3903
max3903 self-requested a review August 20, 2026 15:38
@max3903 max3903 added the needs fixing Changes requested; author needs to fix label Aug 20, 2026

@max3903 max3903 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the 19.0 port, @hector-fe-dev. The l10n_mx_edi.addenda conversion matches the other addendas on this branch, but please work through the list below before merge.

Must fix

  • Restore the 17.0 QWeb tests: render the addenda (addenda.arch or generated CFDI) and assert KNRECEPCION, Purchase_Order, FileNumber_GL, Branch_Centre, and TransportRef for empty and filled values. Do not keep string-contains checks as the only coverage (ir.qweb._render(self.addenda.id) will not work anymore because this is no longer an ir.ui.view).
  • Remove README.rst / static/description/index.html changes on l10n_mx_edi_addenda_audi, l10n_mx_edi_addenda_ford, l10n_mx_edi_addenda_mabe, l10n_mx_edi_addenda_volkswagen, and l10n_mx_edi_addenda_whirlpool. Leave those addons untouched.
  • Keep the root README.md addons table only if gen-addons-table requires it; otherwise revert that too.

PR / git hygiene

  • Rename the PR to [19.0][MIG] l10n_mx_edi_addenda_kuehne_nagel: Migration to 19.0.
  • Add a PR body: short summary, what changed for 19.0, and a Dependencies section.
  • Add labels (needs review, needs fixing, migration, and the module/series labels this repo uses). Already applied.
  • Squash to [MIG] l10n_mx_edi_addenda_kuehne_nagel: Migration to 19.0 plus [UPD] Update l10n_mx_edi_addenda_kuehne_nagel.pot. Drop the wrong technical name l10n_mx_edi_kuehne_nagel from titles and commits.

Should fix

  • Restore https://www.graymatterlogic.com in the test file copyright (replace Gray Matter Logic ().).
  • Put the hidden kn_flag field back on the invoice form (17.0 had it for invisible="not kn_flag"), or confirm the tab still shows without it.

Optional / not blocking

  • Set any empty fields in __manifest__.py instead of removing "icon", "images", and "maintainer". Keep those keys and fill the blank ones.

kn_file_type unused in the QWeb and the http://www.w3.org/2001/XMLSchema namespace are pre-existing on 17.0 — not blocking for this migration.

hector-fe-dev and others added 2 commits August 20, 2026 17:02
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@hector-fe-dev
hector-fe-dev force-pushed the 19.0-mig-l10n_mx_edi_kuehne_nagel branch from f63c894 to 378e83c Compare August 20, 2026 23:10
@hector-fe-dev hector-fe-dev changed the title 19.0 mig l10n mx edi kuehne nagel 19.0][MIG] l10n_mx_edi_addenda_kuehne_nagel: Migration to 19.0 Aug 20, 2026
@amxodoo amxodoo deleted a comment from Hector-OSI Aug 20, 2026

@max3903 max3903 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the force-push, @hector-fe-dev. The module work on l10n_mx_edi_addenda_kuehne_nagel looks good now: QWeb coverage is back via _decode_single_addenda_arch() + _wrap_xml_with_namespaces(), the hidden kn_flag field is on the form, the copyright URL is restored, commits are [MIG] + [UPD], and sibling index.html files are untouched.

Correction from the last review: reverting sibling README.rst files re-broke CI. gen-addon-readme regenerates all addons on every PR and currently wants the OCA banner stripped from the other addendas. Please commit those generated README.rst files (not index.html). Also commit the generated root README.md addons table.

Must fix

  • Fix the PR title: it is missing the opening bracket (19.0][MIG]… → [19.0][MIG] l10n_mx_edi_addenda_kuehne_nagel: Migration to 19.0).
  • Add a ## Dependencies section to the PR body (e.g. all manifest deps already on 19.0).
  • Add "development_status": "Beta" to __manifest__.py (README badge already says Beta; maintainers is already set).
  • Commit the ruff fix: extra blank line after imports in tests/test_account_move.py (pre-commit failed; ruff already auto-fixed it in CI).
  • Commit the generated root README.md addons table (gen-addons-table).
  • Commit the generated sibling README.rst files that only drop the OCA banner (l10n_mx_edi_addenda_audi, _ford, _mabe, _volkswagen, _whirlpool). Leave their index.html and other addon files alone.

Already addressed

  • Restore QWeb tests for KNRECEPCION / Purchase_Order / FileNumber_GL / Branch_Centre / TransportRef.
  • Squash to [MIG] + [UPD] with the real technical name.
  • Restore https://www.graymatterlogic.com in the test copyright.
  • Put the hidden kn_flag field back on the invoice form.

kn_file_type unused in the QWeb and http://www.w3.org/2001/XMLSchema remain pre-existing / not blocking.

@hector-fe-dev hector-fe-dev changed the title 19.0][MIG] l10n_mx_edi_addenda_kuehne_nagel: Migration to 19.0 [19.0][MIG] l10n_mx_edi_addenda_kuehne_nagel: Migration to 19.0 Aug 24, 2026

@max3903 max3903 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hector-fe-dev — the remaining items from the last review are done.

  • Title is [19.0][MIG] l10n_mx_edi_addenda_kuehne_nagel: Migration to 19.0.
  • PR body has ## Dependencies.
  • __manifest__.py has "development_status": "Beta".
  • Ruff blank line in tests/test_account_move.py is gone.
  • Root README.md addons table and sibling README.rst OCA-banner strips are committed.
  • CI is green (pre-commit, gen-addon-readme, gen-addons-table, gen-pyproject).

Not blocking: the two follow-up commits could be squashed into [MIG] (or one [FIX]), and the Notes line about leaving other addendas / the root README unchanged is now stale. Branch name still uses l10n_mx_edi_kuehne_nagel; leave it.

@max3903 max3903 removed the needs fixing Changes requested; author needs to fix label Aug 27, 2026
@max3903
max3903 merged commit 48f8a28 into amxodoo:19.0 Aug 27, 2026
4 checks passed
@max3903
max3903 deleted the 19.0-mig-l10n_mx_edi_kuehne_nagel branch August 27, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

migration mod:l10n_mx_edi_addenda_kuehne_nagel l10n_mx_edi_addenda_kuehne_nagel needs review Needs review series:19.0 Odoo 19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants