[19.0][MIG] l10n_mx_edi_addenda_kuehne_nagel: Migration to 19.0 - #62
Conversation
There was a problem hiding this comment.
Thanks for the 19.0 port, @hector-fe-dev. The l10n_mx_edi.addenda conversion matches the other addendas on this branch, but please work through the list below before merge.
Must fix
- Restore the 17.0 QWeb tests: render the addenda (
addenda.archor generated CFDI) and assertKNRECEPCION,Purchase_Order,FileNumber_GL,Branch_Centre, andTransportReffor empty and filled values. Do not keep string-contains checks as the only coverage (ir.qweb._render(self.addenda.id)will not work anymore because this is no longer anir.ui.view). - Remove
README.rst/static/description/index.htmlchanges onl10n_mx_edi_addenda_audi,l10n_mx_edi_addenda_ford,l10n_mx_edi_addenda_mabe,l10n_mx_edi_addenda_volkswagen, andl10n_mx_edi_addenda_whirlpool. Leave those addons untouched. - Keep the root
README.mdaddons table only ifgen-addons-tablerequires it; otherwise revert that too.
PR / git hygiene
- Rename the PR to
[19.0][MIG] l10n_mx_edi_addenda_kuehne_nagel: Migration to 19.0. - Add a PR body: short summary, what changed for 19.0, and a Dependencies section.
- Add labels (
needs review,needs fixing,migration, and the module/series labels this repo uses). Already applied. - Squash to
[MIG] l10n_mx_edi_addenda_kuehne_nagel: Migration to 19.0plus[UPD] Update l10n_mx_edi_addenda_kuehne_nagel.pot. Drop the wrong technical namel10n_mx_edi_kuehne_nagelfrom titles and commits.
Should fix
- Restore
https://www.graymatterlogic.comin the test file copyright (replaceGray Matter Logic ().). - Put the hidden
kn_flagfield back on the invoice form (17.0 had it forinvisible="not kn_flag"), or confirm the tab still shows without it.
Optional / not blocking
- Set any empty fields in
__manifest__.pyinstead of removing"icon","images", and"maintainer". Keep those keys and fill the blank ones.
kn_file_type unused in the QWeb and the http://www.w3.org/2001/XMLSchema namespace are pre-existing on 17.0 — not blocking for this migration.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
f63c894 to
378e83c
Compare
There was a problem hiding this comment.
Thanks for the force-push, @hector-fe-dev. The module work on l10n_mx_edi_addenda_kuehne_nagel looks good now: QWeb coverage is back via _decode_single_addenda_arch() + _wrap_xml_with_namespaces(), the hidden kn_flag field is on the form, the copyright URL is restored, commits are [MIG] + [UPD], and sibling index.html files are untouched.
Correction from the last review: reverting sibling README.rst files re-broke CI. gen-addon-readme regenerates all addons on every PR and currently wants the OCA banner stripped from the other addendas. Please commit those generated README.rst files (not index.html). Also commit the generated root README.md addons table.
Must fix
- Fix the PR title: it is missing the opening bracket (
19.0][MIG]…→[19.0][MIG] l10n_mx_edi_addenda_kuehne_nagel: Migration to 19.0). - Add a ## Dependencies section to the PR body (e.g. all manifest deps already on
19.0). - Add
"development_status": "Beta"to__manifest__.py(README badge already says Beta;maintainersis already set). - Commit the ruff fix: extra blank line after imports in
tests/test_account_move.py(pre-commitfailed; ruff already auto-fixed it in CI). - Commit the generated root
README.mdaddons table (gen-addons-table). - Commit the generated sibling
README.rstfiles that only drop the OCA banner (l10n_mx_edi_addenda_audi,_ford,_mabe,_volkswagen,_whirlpool). Leave theirindex.htmland other addon files alone.
Already addressed
- Restore QWeb tests for
KNRECEPCION/Purchase_Order/FileNumber_GL/Branch_Centre/TransportRef. - Squash to
[MIG]+[UPD]with the real technical name. - Restore
https://www.graymatterlogic.comin the test copyright. - Put the hidden
kn_flagfield back on the invoice form.
kn_file_type unused in the QWeb and http://www.w3.org/2001/XMLSchema remain pre-existing / not blocking.
max3903
left a comment
There was a problem hiding this comment.
Thanks @hector-fe-dev — the remaining items from the last review are done.
- Title is
[19.0][MIG] l10n_mx_edi_addenda_kuehne_nagel: Migration to 19.0. - PR body has ## Dependencies.
__manifest__.pyhas"development_status": "Beta".- Ruff blank line in
tests/test_account_move.pyis gone. - Root
README.mdaddons table and siblingREADME.rstOCA-banner strips are committed. - CI is green (
pre-commit,gen-addon-readme,gen-addons-table,gen-pyproject).
Not blocking: the two follow-up commits could be squashed into [MIG] (or one [FIX]), and the Notes line about leaving other addendas / the root README unchanged is now stale. Branch name still uses l10n_mx_edi_kuehne_nagel; leave it.
Summary
l10n_mx_edi_addenda_kuehne_nagelto Odoo 19 as anl10n_mx_edi.addendarecord (no longerir.ui.view).invisible="not kn_flag"), including the hiddenkn_flagfield so the tab still shows.KNRECEPCION,Purchase_Order,FileNumber_GL,Branch_Centre, andTransportReffor empty and filled values.Notes
kn_file_typeis still unused in the QWeb, and the addenda still useshttp://www.w3.org/2001/XMLSchema. Both are pre-existing on 17.0 and were left as-is.Test plan
l10n_mx_edi_addenda_kuehne_nagelon a MX company.l10n_mx_edi_addenda_kuehne_nageltests.Dependencies
account— already on 19.0l10n_mx_edi— already on 19.0 (Odoo Enterprise Mexican EDI)