Skip to content

Compilation fix for Mono 4.4 #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OrcJMR wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Compilation fix for Mono 4.4 #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions src/ModernHttpClient/Android/OkHttpNetworkHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ class HostnameVerifier : Java.Lang.Object, IHostnameVerifier

public bool Verify(string hostname, ISSLSession session)
{
return verifyServerCertificate(hostname, session) & verifyClientCiphers(hostname, session);
return verifyServerCertificate(hostname, session);
}

/// <summary>
Expand Down Expand Up @@ -261,22 +261,5 @@ static bool verifyServerCertificate(string hostname, ISSLSession session)
// Call the delegate to validate
return ServicePointManager.ServerCertificateValidationCallback(hostname, root, chain, errors);
}

/// <summary>
/// Verifies client ciphers and is only available in Mono and Xamarin products.
/// </summary>
/// <returns><c>true</c>, if client ciphers was verifyed, <c>false</c> otherwise.</returns>
/// <param name="hostname"></param>
/// <param name="session"></param>
static bool verifyClientCiphers(string hostname, ISSLSession session)
{
var callback = ServicePointManager.ClientCipherSuitesCallback;
if (callback == null) return true;

var protocol = session.Protocol.StartsWith("SSL", StringComparison.InvariantCulture) ? SecurityProtocolType.Ssl3 : SecurityProtocolType.Tls;
var acceptedCiphers = callback(protocol, new[] { session.CipherSuite });

return acceptedCiphers.Contains(session.CipherSuite);
}
}
}