Repository navigation
Conversation
|
Supervisor review note for Koenkk#871: The runtime approach is now implemented and CI-clean on this fork-local draft. The key behavior is intentionally one-way: an unclassified The narrow sparse endpoint fingerprint is retained so the known SUTON Before proposing this upstream, the remaining evidence point from Koenkk#871 is simple: please confirm from a physically affected single-phase unit whether DP7 or DP8 ever appears, even as zero-valued telemetry. If the 1P device is genuinely DP6-only, this runtime discriminator avoids guessing phase count from the shared static fingerprint. Validation on current head: Build PASS, Biome Check PASS, full Test PASS, Bench PASS, autofix PASS. |
|
New evidence from zigbee2mqtt/hassio-zigbee2mqtt#871 materially supports the runtime discriminator:
Supervisor interpretation: keep the draft implementation, but describe the heuristic as one-way runtime detection: an unclassified device remains single-phase-compatible unless DP7 or DP8 is observed; DP7/DP8 is positive evidence for 3P and is persisted. The remaining validation target is classification latency/safety on real 3P units (especially whether I would still welcome a longer Koenkk#871 capture until DP6 appears, because it would directly confirm the generic electrical decode path on the affected hardware, but the current evidence already confirms the most important negative condition: no DP7/DP8 on those physical 1P units. |
|
Hi |
|
Additional Koenkk#871 evidence: the reporter repeated active debug captures on both physical 1P units and again saw no DP7 or DP8 at all, including zero-valued reports. DP6 still did not appear, so this draft should continue to describe the heuristic as one-way: unclassified remains 1P-compatible; DP7/DP8 is candidate positive evidence for 3P. The 1P negative condition is now substantially better supported, but upstream promotion remains blocked until our P019 test proves that the exact |
Superseded by #6.
The runtime phase-count classifier explored here is no longer the preferred design because absence of DP7/DP8 during startup/query was not reliable enough to classify a physical variant safely.
Final proposal: #6 keeps the collision family on the shared definition and makes phase order an explicit per-device
phase_mappingoption.