-
Notifications
You must be signed in to change notification settings - Fork 0
Fix: correct speechText for Message_Stream_Event #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ao-anam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 7 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="README.md">
<violation number="1" location="README.md:135">
P2: The example now references `Message` but the import was removed. This makes the snippet invalid when copied. Add `Message` to the import list.</violation>
</file>
<file name="examples/persona_interactive_video.py">
<violation number="1" location="examples/persona_interactive_video.py:41">
P3: The comment says the log level was reduced to WARNING, but the code now sets INFO. This mismatch makes the logging intent unclear for maintainers.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 7 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/anam/_streaming.py">
<violation number="1" location="src/anam/_streaming.py:345">
P2: Reset _data_channel_open to False when creating a new data channel; otherwise stale True values from a previous session can cause sends while the new channel is still connecting.</violation>
</file>
<file name="examples/persona_interactive_video.py">
<violation number="1" location="examples/persona_interactive_video.py:41">
P3: The comment on the logging level no longer matches the code (INFO vs “reduced to WARNING”), which is misleading for maintenance.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Fixing message type for Message_Stream_Event. Fixing message processing, fixing message history
Expand interactive example using MESSAGE_STREAM_EVENTS for live caption and printing the whole message history at the end of a session.
Summary by cubic
Adds real-time message streaming support using speechText events and builds automatic conversation history. Fixes message parsing and improves the interactive example with live captions and transcript printing.
New Features
Bug Fixes
Written for commit 8229024. Summary will update on new commits.