chore[PH-40]: unit tests setup with Vitest + CL1 tests#7
Draft
chore[PH-40]: unit tests setup with Vitest + CL1 tests#7
Conversation
ancarofl
commented
Jul 30, 2025
| type: "error", | ||
| }, | ||
| { | ||
| description: "undefined session id", |
Owner
Author
There was a problem hiding this comment.
Defining all this seems bad, I should reuse the errors I created but haven't found a nice way to do that yet
ancarofl
force-pushed
the
chore/PH-40_CL1_UT
branch
from
5311cbe to
1273920
Compare
ancarofl
commented
Aug 3, 2025
| }, | ||
| ]; | ||
|
|
||
| describe("GET /api/[provider]/oauth", () => { |
Owner
Author
There was a problem hiding this comment.
This is interesting - the test was working with the wrong route (not /oauth but /authorization) cuz it uses the imported route handler (at the top of the file), not what I type here. So it literally does not matter what I type here, which I find pretty strange. But ofc it makes sense cuz otherwise https://example.com wouldn't work right
The dynamic route params are passed directly (const params = { provider: provider as PlatformKey };). The query params in the URL are parsed and used by the handler. So those matter.
ancarofl
changed the title
|
Looks good, I approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.