Bump Erlang/OTP, rebar3, and ELP version pins to latest - #194
Merged
Merged
Conversation
Bump the rebar3 CI matrix pin and .tool-versions erlang pin to their latest patch releases, and update the CI ELP download to the latest ELP release (2026-08-10), which now also ships an OTP 29 build. Migrate .elp_lint.toml to ELP's new [linters.<code>] config schema required by that release. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The 2026-08-10 ELP release always lints test files now (previously skipped). Scope the newly-triggered noisy lints (unused record fields, module-level nowarn, old EDoc comments, maps:put/maps:reverse idioms, and a parse error from the test-only spectra_transform parse_transform) back to non-test code via include_tests = false, restoring prior lint scope. Also fix the one genuine new finding in production code: replace maps:find/2 with map-pattern matching in spectra_json:struct_default_value/2 (W0032). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…form ELP cannot execute arbitrary parse transforms during analysis (see WhatsApp/erlang-language-platform#39), so files applying the project's own spectra_transform parse_transform fail to parse under elp lint with L0002. Use ELP's documented elp:ignore mechanism on each affected test file instead of the ineffective include_tests config key (L0002 is a hard parse failure, not a post-parse lint, so it isn't scoped by include_tests). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rebar3matrix pin (3.25→3.27) and.tool-versionserlangpin (28.2→28.5.0.6) to their latest patch releases; the OTP CI matrix already builds29/28/27via major-version pins thaterlef/setup-beamresolves to the latest patch automatically.2026-08-10), which now ships an OTP 29 build, and add that build to the matrix (previously lint/type_check were skipped on OTP 29)..elp_lint.tomlto ELP's new[linters.<code>]config schema, required by the newer ELP release.make type_checkdepends on both.Test plan
make format/make compileon Erlang 28.5.0.6make lintwith the migrated.elp_lint.tomland new ELP build