[FEATURE] Add XLIFF file processor package#392
Open
chrissonntag wants to merge 3 commits into
Open
Conversation
- ✨ Introduced `EnsureXliffHasSourceLanguageFractor` to ensure source-language attribute is present in XLIFF files. - ✨ Introduced `EnsureXliffHasTargetLanguageFractor` to add target-language attribute based on filename. - ✨ Added `ConvertXliff1To2Fractor` for converting XLIFF 1.2 files to XLIFF 2.0 format. - 🧪 Created tests for the new rules with various fixture files to validate functionality. - 📄 Added configuration files for the new rules to integrate with the Fractor framework. - 🛠️ Implemented necessary value objects and factories for handling XLIFF documents and configurations.
Collaborator
|
Please move the rules in the according namespace the same way as the TYPO3 rules are organized. This will have an impact in the rendering of the documentation for better clarity. |
Collaborator
|
Hey Chris, can we move forward with this one as I would really like to bring this into a state where it can be merged? |
Contributor
Author
|
Hi Simon, of course. I'll look into it this weekend! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new package
a9f/fractor-xlifffor processing XLIFF translation files. The package supports XLIFF versions 1.0, 1.1, 1.2, and 2.0 and ships with three rules:Code Quality / Validation:
source-language) and v2.0 (srcLang).Transformation:
trans-unittounit/segment) and remapping attributes accordingly.The package follows the same architecture as the existing file processors (XML, YAML, etc.) with configurable file extensions, indentation settings, and full integration into the Fractor runner pipeline.
ProcessorSkipper tests have been extended to cover
XliffFileProcessoralongside the five existing processors.