Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/typo3-fractor/config/typo3-8.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

declare(strict_types=1);

use a9f\Typo3Fractor\TYPO3v8\Fluid\ReplaceCaseDefaultWithDefaultCaseFluidFractor;
use a9f\Typo3Fractor\TYPO3v8\TypoScript\RemoveConfigPrefixLocalAnchorsFractor;
use a9f\Typo3Fractor\TYPO3v8\TypoScript\RemoveConfigRenderCharsetFractor;
use a9f\Typo3Fractor\TYPO3v8\TypoScript\RemoveModNewPageWizOverrideWithExtensionFractor;
Expand All @@ -13,6 +14,7 @@
->autoconfigure()
->autowire();

$services->set(ReplaceCaseDefaultWithDefaultCaseFluidFractor::class);
$services->set(RemoveConfigPrefixLocalAnchorsFractor::class);
$services->set(RemoveConfigRenderCharsetFractor::class);
$services->set(RemoveModNewPageWizOverrideWithExtensionFractor::class);
Expand Down
18 changes: 17 additions & 1 deletion packages/typo3-fractor/docs/typo3-fractor-rules.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# 69 Rules Overview
# 70 Rules Overview

## AbstractMessageGetSeverityFluidFractor

Expand Down Expand Up @@ -1471,6 +1471,22 @@ Rename key mail to email for MailLinkHandler

<br>

## ReplaceCaseDefaultWithDefaultCaseFluidFractor

Replace f:case with default attribute by f:defaultCase

- class: [`a9f\Typo3Fractor\TYPO3v8\Fluid\ReplaceCaseDefaultWithDefaultCaseFluidFractor`](../rules/TYPO3v8/Fluid/ReplaceCaseDefaultWithDefaultCaseFluidFractor.php)

```diff
<f:switch expression="{someVariable}">
<f:case value="foo">foo</f:case>
- <f:case default="true">bar</f:case>
+ <f:defaultCase>bar</f:defaultCase>
</f:switch>
```

<br>

## TranslationFileYamlFractor

Use key translationFiles instead of translationFile
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<f:switch expression="{someVariable}">
<f:case value="foo">foo</f:case>
<f:case default="true">bar</f:case>
</f:switch>
-----
<f:switch expression="{someVariable}">
<f:case value="foo">foo</f:case>
<f:defaultCase>bar</f:defaultCase>
</f:switch>
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<?php

declare(strict_types=1);

namespace a9f\Typo3Fractor\Tests\TYPO3v8\Fluid\ReplaceCaseDefaultWithDefaultCaseFluidFractor;

use a9f\Fractor\Testing\PHPUnit\AbstractFractorTestCase;
use PHPUnit\Framework\Attributes\DataProvider;

final class ReplaceCaseDefaultWithDefaultCaseFluidFractorTest extends AbstractFractorTestCase
{
#[DataProvider('provideData')]
public function test(string $filePath): void
{
$this->doTestFile($filePath);
}

public static function provideData(): \Iterator
{
return self::yieldFilesFromDirectory(__DIR__ . '/Fixtures', '*.html.fixture');
}

public function provideConfigFilePath(): string
{
return __DIR__ . '/config/fractor.php';
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?php

declare(strict_types=1);

use a9f\Fractor\Configuration\FractorConfiguration;
use a9f\Typo3Fractor\TYPO3v8\Fluid\ReplaceCaseDefaultWithDefaultCaseFluidFractor;

return FractorConfiguration::configure()
->withRules([ReplaceCaseDefaultWithDefaultCaseFluidFractor::class]);
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
<?php

declare(strict_types=1);

namespace a9f\Typo3Fractor\TYPO3v8\Fluid;

use a9f\FractorFluid\Contract\FluidFractorRule;
use Nette\Utils\Strings;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;

/**
* @changelog https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/8.0/Breaking-69863-ChangesInViewHelpersPostFluidStandalone.html
* @see \a9f\Typo3Fractor\Tests\TYPO3v8\Fluid\ReplaceCaseDefaultWithDefaultCaseFluidFractor\ReplaceCaseDefaultWithDefaultCaseFluidFractorTest
*/
final class ReplaceCaseDefaultWithDefaultCaseFluidFractor implements FluidFractorRule
{
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Replace f:case with default attribute by f:defaultCase', [new CodeSample(
<<<'CODE_SAMPLE'
<f:switch expression="{someVariable}">
<f:case value="foo">foo</f:case>
<f:case default="true">bar</f:case>
</f:switch>
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
<f:switch expression="{someVariable}">
<f:case value="foo">foo</f:case>
<f:defaultCase>bar</f:defaultCase>
</f:switch>
CODE_SAMPLE
)]);
}

public function refactor(string $fluid): string
{
// Replace opening + closing tag with content
$fluid = Strings::replace(
$fluid,
'#<f:case\s+default="(true|1)"\s*>(.*?)</f:case>#si',
'<f:defaultCase>$2</f:defaultCase>'
);

// Replace self-closing tag
return Strings::replace($fluid, '#<f:case\s+default="(true|1)"\s*/>#si', '<f:defaultCase />');
}
}