Repository navigation
Upgrade to Ruby 3.4 and nokogiri 1.19.4; build pull requests - #3
Merged
Merged
Conversation
nokogiri 1.19.x, which fixes the open Dependabot alerts, requires Ruby 3.2 or newer, and Ruby 3.1 is end-of-life. Pin Ruby 3.4 in .ruby-version and have the workflow read it, so local and CI builds match. Also build and link-check pull requests (without deploying), so changes are tested before they reach master. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the open Dependabot alerts for
nokogiri(11 alerts, up to high severity) by updating it from 1.18.10 to 1.19.4.nokogiri1.19.x requires Ruby 3.2 or newer, so this also moves the site from Ruby 3.1 (end-of-life since March 2025) to Ruby 3.4.nokogiriis only used byhtml-proofer, the link checker in the build. It isn't part of the published site.Changes
.ruby-version(new): pins Ruby 3.4. The workflow now reads it, so local and GitHub builds use the same Ruby.Gemfile.lock:nokogiri1.19.4 for macOS and Linux. Bundler is now 4.0.21, the version that ships with Ruby 3.4..github/workflows/pages-deploy.yml: pull requests intomasternow run the build and link check, but never deploy. Deploys still happen only on pushes tomaster, and pull request builds use their own concurrency group, so they can't block a deploy.Testing
htmlprooferpasses, and the same pages are produced as before.After merging
For local previews, run Jekyll with Ruby 3.4, for example:
PATH=/opt/homebrew/opt/ruby@3.4/bin:$PATH bundle exec jekyll serve🤖 Generated with Claude Code