chore: 🔧 refactor TypeScript configuration files#3
Merged
Merged
Conversation
Removed obsolete tsconfig.build.json and created separate tsconfig files for library, node, and test configurations to improve project structure and clarity.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors TypeScript configuration by replacing the obsolete tsconfig.build.json with three specialized configuration files to improve project organization and clarity.
- Removed the obsolete
tsconfig.build.jsonconfiguration file - Created three new specialized TypeScript configurations: library, node, and test environments
- Updated Vite configuration to reference the new TypeScript config files
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Updated to use new tsconfig.lib.json and tsconfig.test.json references |
| tsconfig.test.json | New TypeScript configuration specifically for test files with testing types |
| tsconfig.node.json | New TypeScript configuration for Node.js environment files |
| tsconfig.lib.json | New TypeScript configuration for library source code with React support |
| tsconfig.build.json | Removed obsolete build configuration file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| environment: 'jsdom', | ||
| setupFiles: ['src/setupTests.ts'], | ||
| include: ['src/**/*.{test,spec}.{ts,tsx}'], | ||
| typecheck: { |
There was a problem hiding this comment.
Inconsistent indentation: the 'typecheck' property has 8 spaces while the 'tsconfig' property has 6 spaces. Both should use consistent indentation.
Suggested change
| typecheck: { | |
| typecheck: { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed obsolete tsconfig.build.json and created separate tsconfig files for library, node, and test configurations to improve project structure and clarity.