Start the pattern editor on the Halloween preset (0.6.1) - #23
Merged
Merged
Conversation
The editor's STARTING_PATTERN still had the old two-color orange and purple after 0.5.1 changed the preset. Match the preset, and add a test that reads the constant out of PatternPage.jsx so the two can't drift apart again. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pattern editor's starting pattern, shown when a group has no pattern yet, didn't match the built-in Halloween preset. It still had the old two-color version from before 0.5.1: orange
255,152,0at 80 and purple at 20. It now matches the preset: orange255,126,0at 80, purple at 15 and yellow255,236,0at 5.frontend/src/PatternPage.jsx:STARTING_PATTERNnow matchesdefault_presets()["Halloween"], with a comment on each side pointing at the other.tests/test_presets.py:test_the_editor_starts_on_the_halloween_presetreadsSTARTING_PATTERNout ofPatternPage.jsxand compares it with the preset. It fails on the old constant, so the two can't drift apart silently again.pyproject.toml,frontend/package.jsonand the add-on'sconfig.yaml, both locks refreshed, and notes indocs/releases/0.6.1.md. There have been no Dependabot merges since v0.6.0.Tested: 342 Python tests, the frontend tests and the format checks.
🤖 Generated with Claude Code