Skip to content

Fix URL-encoded Unicode artifact links - #225

Open
kudala-bharani wants to merge 2 commits into
andrewyng:mainfrom
kudala-bharani:agent/fix-artifact-preview-links
Open

Fix URL-encoded Unicode artifact links#225
kudala-bharani wants to merge 2 commits into
andrewyng:mainfrom
kudala-bharani:agent/fix-artifact-preview-links

Conversation

@kudala-bharani

@kudala-bharani kudala-bharani commented Jul 27, 2026

Copy link
Copy Markdown

Fixes #223

What changed

  • Decode URL-encoded artifact paths before displaying or opening them.
  • Preserve filenames containing literal percent signs when decoding is not possible.
  • Add regression coverage for URL-encoded Unicode filenames.

Upstream reconciliation

Current main now handles artifact reads across the workspace, scratch directory, and granted roots, while intentionally keeping the Artifacts list scratch-only. This branch was updated to preserve that architecture, and the superseded broad-root scanning changes were dropped.

Validation

  • npm test -- src/components/Markdown.test.tsx — 5 passed
  • npm test — 22 files / 140 tests passed
  • npx tsc --noEmit — passed
  • npm run build — passed

The Playwright browser suite could not complete locally because its Vite test server stopped responding during page navigation; the focused regression passes, and that browser failure occurred before the tested interaction.

@kudala-bharani
kudala-bharani marked this pull request as ready for review July 27, 2026 04:43
@kudala-bharani
kudala-bharani force-pushed the agent/fix-artifact-preview-links branch from 2ae3679 to 3739653 Compare August 1, 2026 16:58
@kudala-bharani kudala-bharani changed the title Fix artifact previews across granted roots Fix URL-encoded Unicode artifact links Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

link in Markdown doesn't open file preview

1 participant