Skip to content

security: negated denials ("no, don't approve") no longer resolve as allow #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coderdailyone wants to merge 1 commit into
base: main
Choose a base branch
from
Open

security: negated denials ("no, don't approve") no longer resolve as allow #560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tests/test_inbox_routing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,15 @@ def test_denied_and_approved_word_forms(tmp_path):
assert store.get(b.id).resolution == "allow"


def test_negated_denial_is_not_parsed_as_allow(tmp_path):
"""A denial phrased with an allow word ("no, don't approve") must never release the item."""
store = InboxStore(tmp_path / "inbox.json")
for phrasing in ("no, don't approve", "not allowed", "no, do not allow this"):
item = store.add_approval("s1", "Deploy?", inbox="ops")
resolve_from_reply(f"{phrasing} [ow:{item.id}]", store.resolve)
assert store.get(item.id).resolution != "allow"


def test_emoji_reactions_still_resolve(tmp_path):
store = InboxStore(tmp_path / "inbox.json")
a = store.add_approval("s1", "Deploy?", inbox="ops")
Expand Down
Loading