security: require approval for persistent memory mutations - #565
Open
harneet2512 wants to merge 1 commit into
Open
security: require approval for persistent memory mutations#565harneet2512 wants to merge 1 commit into
harneet2512 wants to merge 1 commit into
Conversation
harneet2512
force-pushed
the
fix/persistent-memory-approval
branch
from
August 26, 2026 15:01
981b2e3 to
184d8cd
Compare
Author
|
Refreshing the source branch after correcting commit author metadata; reopening immediately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Add
remember,memory_update, andmemory_forgettoPERSISTENT_AUTHORITY_TOOLS.These tools modify durable memory that is loaded into later sessions and future system prompts. They now require explicit human approval in every permission mode, even if tool metadata omits
requires_approval.memory_readis unchanged.Tests
Added regression coverage for all three mutations across every permission mode, including the metadata-omission case.
Follow-up hardening for the persistent memory feature introduced in #536.