toolchain: add linux_arm64 builds for gitleaks, trivy and osv-scanner - #572
Open
CyberDefenseOperations wants to merge 1 commit into
Open
Conversation
MANAGED lists all three tools, but each downloads map carried only darwin_arm64, darwin_amd64 and linux_amd64. _platform_key() maps aarch64 -> arm64, so on Linux ARM64 describe() returns None for every managed tool. The engine then takes the 'not in the pinned catalog' branch and never emits TOOL_REQUESTED, so the install card is unreachable and request_tool always reports the tool as unavailable -- which is the silent-gap failure OPE-85 exists to prevent, on a platform where all three tools are in fact available. It also fails three tests on that platform: tests/test_tool_request.py::test_emits_tool_requested_and_reports_install tests/test_tool_request.py::test_declining_tells_the_agent_to_fall_back_openly tests/test_tool_request.py::test_decline_recheck_finds_a_copy_the_user_installed_themselves All three projects publish linux_arm64 assets. Each was downloaded, checksummed and executed on aarch64 before being pinned here: gitleaks 8.30.1 ELF 64-bit LSB executable, ARM aarch64 trivy 0.74.0 ELF 64-bit LSB executable, ARM aarch64 osv-scanner 2.5.0 ELF 64-bit LSB executable, ARM aarch64 Asset naming differs per project and is preserved as each publishes it; osv-scanner ships a bare binary, so its entry has no member=, matching its existing entries. Backend suite on aarch64: 4189 passed, 0 failed (was 3 failed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MANAGEDlistsgitleaks,trivyandosv-scanner, but eachdownloadsmap carriesonly
darwin_arm64,darwin_amd64andlinux_amd64._platform_key()mapsaarch64→arm64, so on Linux ARM64:With
describe()returningNone,_run_tool_requesttakes theelif _toolchain.describe(name) is Nonebranch added in 1e564d5 and returns"'gitleaks' is not in the pinned tool catalog" without ever emitting
TOOL_REQUESTED. The install card is unreachable, and an agent that needs one of thesescanners is told the tool cannot be installed — on a platform where all three are, in
fact, published.
That is the silent-gap failure OPE-85 exists to prevent: "A missing tool must become a
visible decision, never an invisible gap." On ARM64 Linux it is currently an invisible
gap.
Also fails three tests on that platform
Each asserts a
TOOL_REQUESTEDevent that the catalog gap prevents from being emitted.They pass on x64, which is why CI has not surfaced this — the matrix does not currently
build on ARM64 Linux (cf. #218).
The change
Purely additive: one
linux_arm64entry per tool, no logic touched.Every checksum below was produced by downloading the asset and running it on
aarch64—none is copied from a release page:
fileoutput--versionELF 64-bit LSB executable, ARM aarch648.30.1ELF 64-bit LSB executable, ARM aarch64Version: 0.74.0ELF 64-bit LSB executable, ARM aarch64osv-scanner version: 2.5.0Asset naming differs per project and is preserved exactly as each publishes it —
gitleaks_8.30.1_linux_arm64.tar.gz,trivy_0.74.0_Linux-ARM64.tar.gz, and a bareosv-scanner_linux_arm64binary. osv-scanner ships an unarchived binary, so its entry hasno
member=, consistent with its existingdarwin_*/linux_amd64entries.After
Backend suite on aarch64: 4189 passed, 1 skipped, 0 failed (was
3 failed).Tested on Linux aarch64 (Ubuntu, Python 3.12). No change in behaviour on any existing
platform — the three new keys are only reachable when
_platform_key()returnslinux_arm64.