fix(automation): persist cancelled scheduled runs - #580
Open
gopi1949 wants to merge 1 commit into
Open
Conversation
Finalize the existing run record when scheduler shutdown cancels execution, interrupt active engine work, and preserve completed work when only its notification is cancelled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Scheduler shutdown raises
asyncio.CancelledError, which bypassesexcept Exception. Because aTaskRunis persisted asrunningbefore execution begins, cancellation could leave that record stuck as running forever.Fix
error, setfinished_at, persist it, and re-raise so an incomplete schedule is not advanced.okand return normally so the scheduler advances instead of replaying side effects after restart.Tests
Regression coverage now exercises cancellation during:
Six focused scheduler/automation tests pass. The full backend suite on Windows reports 1840 passed, 21 failed, and 4 skipped; the 21 failures are the existing Windows baseline and this change adds no new failures.