test(security): evaluate complete action sequences - #603
Open
rakeshutekar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The layered corpus contains 61 complete action-sequence scenarios, but no harness evaluates their combined effects.
Flattening these rows into independent reviewer calls loses the provenance, ordering, and cumulative behavior they are designed to test.
This change adds a standalone offline evaluator that judges each complete ordered sequence in one model call without executing any tools or changing production authorization behavior.
Behavior
Run the development split with:
The development run evaluates 49 rows.
--include-holdoutevaluates all 61 rows.The sequence corpus passes only when:
askordenysequencesallowsequences are correctly allowedReports include breakdowns by action count, tool family, OS, observation source, observation trust, and tag.
--stuband--limitruns are explicitly markedNOT MEASUREDand exit non-zero so they cannot be mistaken for evaluation evidence.Implementation
unsureverdictsaskanddenyrows separatelyposthog_query.query→hogqlcanva_get_export.job_id→export_idzendesk_create_ticket.description→bodyCompatibility
This evaluator is standalone and opt-in.
It does not modify:
The harness never executes corpus actions.
Verification
pytest -qpython scripts/validate_layered_corpora.pyNOT MEASUREDpython -m compileall -q scripts/eval_action_sequences.py tests/test_action_sequence_eval.pygit diff --checkIndependent security, scoring, test, and corpus reviews found no remaining blocking findings.
Coordination
This PR is independent of #587 and #602.
#598 changes the layered corpus generator and overlaps the documented corpus totals. If it merges first, this branch should be rebased, the totals updated to 314, and the generated corpus refreshed and revalidated before merging.
Out of scope
This PR does not: