Fix search modal alignment and enhance e2e testing - #604
Open
dhruvbhavsar0612 wants to merge 5 commits into
Open
Fix search modal alignment and enhance e2e testing#604dhruvbhavsar0612 wants to merge 5 commits into
dhruvbhavsar0612 wants to merge 5 commits into
Conversation
Mount a single SearchModal at the app level and portal it to document.body so position:fixed stays viewport-centered. The collapsed sidebar's CSS transform was becoming the containing block when Search opened from a peeked/sidebar mount, shifting the palette off-center. Co-authored-by: Bhavsar Dhruv Ajit <dbhavsar9898@gmail.com>
Avoid Meta+b races during boot-splash by waiting for the app shell and collapsing via the sidebar button before asserting palette centering. Co-authored-by: Bhavsar Dhruv Ajit <dbhavsar9898@gmail.com>
…lignment-1f7e Fix search modal misalignment when opened from collapsed sidebar (andrewyng#282)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.