Windows: put per-user files under %APPDATA% - #39
Merged
Merged
Conversation
> Drafted by Claude (Opus 5), an LLM by Anthropic, at andy5995's
> direction.
Windows sets no HOME, so homeInit() fell through to the directory the program
was started from. Launched from the Start Menu shortcut that is the install
directory under {autopf}, which is not writable without elevation, so the
configuration file could not be written and startup reported "Error writing
config file".
%APPDATA%\ncmail now comes between HOME and that fallback, and is created
there rather than in verifyPaths(), which runs after the configuration file
has already been written. getenv is used rather than
SHGetFolderPath(CSIDL_APPDATA): the shell fills APPDATA from the same place
for a program a user launched, while the API would need shell32 adding to the
MSVC meson deps, Makefile.vc, and two Win32 targets nothing builds.
Only running ncmail from inside an MSYS2 shell is unaffected, because that
shell sets HOME itself. That is not the same as the installer, which MSYS2
merely builds: the installed program launched from Explorer or the Start Menu
has no HOME, which is the case reported.
Fixes #38
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows sets no HOME, so homeInit() fell through to the directory the program was started from. Launched from the Start Menu shortcut that is the install directory under {autopf}, which is not writable without elevation, so the configuration file could not be written and startup reported "Error writing config file".
%APPDATA%\ncmail now comes between HOME and that fallback, and is created there rather than in verifyPaths(), which runs after the configuration file has already been written. getenv is used rather than SHGetFolderPath(CSIDL_APPDATA): the shell fills APPDATA from the same place for a program a user launched, while the API would need shell32 adding to the MSVC meson deps, Makefile.vc, and two Win32 targets nothing builds.
Only running ncmail from inside an MSYS2 shell is unaffected, because that shell sets HOME itself. That is not the same as the installer, which MSYS2 merely builds: the installed program launched from Explorer or the Start Menu has no HOME, which is the case reported.
Fixes #38