eric-oyanadel#4
Open
Aereli wants to merge 3 commits into
Open
Conversation
Comment on lines
+103
to
+104
| grid-template-columns: 1fr 1fr 1fr; | ||
| grid-template-rows: 1fr 1fr 1fr; |
Owner
There was a problem hiding this comment.
just curious, does it look the same if you take these two lines out? I have a feeling it would -- let me know!
Comment on lines
+111
to
+113
| display: grid; | ||
| grid-column: 2; | ||
| grid-row: 2; |
Owner
There was a problem hiding this comment.
Not sure if you need these either -- Let me know if it works, I will check myself tomorrow as well.
Author
There was a problem hiding this comment.
wow. Yes you are correct. I check it out in the chrome: inspect and it looks just fine.
Will create another pull soon.
Owner
|
No need to make a new PR, just make a new commit on this same branch and push it up. The PR will auto-update!
… On Oct 4, 2019, at 9:41 AM, Eric Manuel Oyanadel ***@***.***> wrote:
@Aereli commented on this pull request.
In index.html <#4 (comment)>:
> + display: grid;
+ grid-column: 2;
+ grid-row: 2;
wow. Yes you are correct. I check it out in the chrome: inspect and it looks just fine.
Will create another pull soon.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#4?email_source=notifications&email_token=AB55PISSTR2THBEMEWMVHRTQM5BZLA5CNFSM4I5KJKT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCG5TMHQ#discussion_r331507310>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB55PIQMEWDTZTMR3KIA23TQM5BZLANCNFSM4I5KJKTQ>.
|
JamesKemp296
approved these changes
Dec 13, 2019
Contributor
JamesKemp296
left a comment
JamesKemp296
left a comment
There was a problem hiding this comment.
I gotta say, this is some fantastic css grid code and it's a shame it was never pulled into master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the flag Japan.
Learned ALOT about grid. also updated the readME and set the size to the correct proportions of the flag via wikipedia.