Skip to content

feat(preflight): add plugin, API version, and image checks before deploy #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madhugoutham wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(preflight): add plugin, API version, and image checks before deploy #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d1ed29
feat(preflight): add plugin, API version, and image checks before deploy
madhugoutham Aug 4, 2026
b3f704f
merge: resolve conflict with main GPU gating
madhugoutham Aug 5, 2026
36c1888
fix(preflight): address review findings with fail-closed Layer-2
madhugoutham Aug 11, 2026
45f5f9f
fix(preflight): address all review findings
madhugoutham Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/conformance/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,14 @@ def main():
parser.add_argument("--decode-node-selector", default="", help="Node selector for decode pods (key=value)")
parser.add_argument("--prefill-node-selector", default="", help="Node selector for prefill pods (key=value)")

# Preflight
parser.add_argument(
"--router-repo",
default="",
metavar="PATH",
help="Local llm-d-router checkout for preflight Layer-2 plugin source extract",
)

# Behavior
parser.add_argument("--nocleanup", action="store_true", help="Keep resources after test")
parser.add_argument(
Expand Down Expand Up @@ -157,6 +165,7 @@ def main():
"guidellm_image": "--guidellm-image",
"decode_node_selector": "--decode-node-selector",
"prefill_node_selector": "--prefill-node-selector",
"router_repo": "--router-repo",
}

for attr, flag in flag_map.items():
Expand Down
2 changes: 2 additions & 0 deletions src/conformance/deployer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ def __init__(
manifest_dir: str = "deploy/manifests",
decode_node_selector: str = "",
prefill_node_selector: str = "",
router_repo: str = "",
):
self.kubeconfig = kubeconfig
self.platform = platform
Expand All @@ -93,6 +94,7 @@ def __init__(
self.manifest_dir = Path(manifest_dir)
self.decode_node_selector = _parse_node_selector(decode_node_selector)
self.prefill_node_selector = _parse_node_selector(prefill_node_selector)
self.router_repo = router_repo
self._port_forward_proc: subprocess.Popen | None = None
self._port_forward_port: int = 0
self._pod_pf_proc: subprocess.Popen | None = None
Expand Down
Loading