Skip to content

fix: node pipelines breaking#595

Draft
fdewas-aneo wants to merge 16 commits into
mainfrom
fd/fix/node-pnpm-token-registery
Draft

fix: node pipelines breaking#595
fdewas-aneo wants to merge 16 commits into
mainfrom
fd/fix/node-pnpm-token-registery

Conversation

@fdewas-aneo
Copy link
Copy Markdown
Contributor

@fdewas-aneo fdewas-aneo commented Feb 18, 2025

Motivation

Pipelines involving node have broken in two different ways:

  • The pnpm integrity key is no longer accepted by npm on pipelines running on node@20.x.x. (for ci.yml)
  • The pnpm cache does no longer exist, breaking the Doc pipelines.

Description

In order to fix the first problem, i tried to update pnpm to its lastest version, after the breaking integrity key was introduced. If it does not work, the solution reside in this comment, which include adding a new step to the lint JS pipeline.

For the second problem, if it is not fixed by the first solution, the solution might reside in adding a new step to the docs pipelines whose role would be to install (and so cache) the dependencies, as sugested by this comment

Testing

[When applicable, detail the testing you have performed to ensure that these changes function as intended. Include information about any added tests.]

Impact

[Discuss the impact of your modifications on ArmoniK. This might include effects on performance, configuration, documentation, new dependencies, or changes in behaviour.]

Additional Information

[Any additional information that reviewers should be aware of.]

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 18, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1488 1257 84% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: f0cfbfa by action🐍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant