Hugov/mmap taskhandler#652
Open
HugoVuach wants to merge 4 commits into
Open
Conversation
|
Hugo Vuacheux seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current
TaskHandlereagerly loads the payload and all data dependencies into memory, which can be costly for large inputs. This PR refactors the implementation to reduce copies and memory usage while keeping backward compatibility.Description
Introduces lazy loading of payload and data dependencies using
mmap.Adds zero-copy APIs:
getPayloadView()returning anabsl::string_viewgetDataDependenciesView()returningstd::map<std::string, absl::string_view>Keeps existing APIs (
getPayload(),getDataDependencies()) by building owning caches on demand.Refactors result writing: replaces
ofstreamwith mmap write + memcpy + msync, keeping mappings alive untilTaskHandlerdestruction.Adds centralized cleanup of mappings (RAII via destructor).
Testing
*View()and owning getters; result file is written andNotifyResultDatasucceeds.Impact
mmapusage (portability consideration for non-POSIX platforms).absl::string_viewlifetimes are tied to theTaskHandlerinstance.Additional Information
Checklist