Skip to content

fix: merge of TaskOptions and TaskOptions validator#1090

Open
PierrePicard20 wants to merge 1 commit into
mainfrom
ppi/mergeTaskOption
Open

fix: merge of TaskOptions and TaskOptions validator#1090
PierrePicard20 wants to merge 1 commit into
mainfrom
ppi/mergeTaskOption

Conversation

@PierrePicard20
Copy link
Copy Markdown
Contributor

Motivation

Some merging rules in TaskOptions were inverted and session's default TaskOptions validator should differ from task's TaskOptions validator.

Description

Fix the rules of merge of TaskOptions, and introduce a parameter in TaskOptions validator to differentiate sessions case from tasks case.

Testing

Added unit tests for TaskOptions validator

Impact

Fix merge of TaskOptions and TaskOptions validator

Additional Information

None

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 20, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants