Skip to content

fix: file already exists #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dbrasseur-aneo wants to merge 1 commit into
base: 0.12.x
Choose a base branch
from
Draft

fix: file already exists #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Worker/src/Common/Adapter/S3Adapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,15 @@ await r.WriteResponseStreamToFileAsync(materializedFileName,
false,
cancellationToken)
.ConfigureAwait(false);

File.Move(materializedFileName,
targetFileName);
try
{
File.Move(materializedFileName,
targetFileName);
}
catch (IOException ioException)
{
// File already exists
}
Comment on lines +124 to +127
Copy link
Copy Markdown
Contributor

@aneojgurhem aneojgurhem Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something finer than that ? It looks a bit wide to me

Copy link
Copy Markdown
Contributor Author

@dbrasseur-aneo dbrasseur-aneo Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://learn.microsoft.com/fr-fr/dotnet/api/system.io.file.move?view=net-8.0#system-io-file-move(system-string-system-string) It's the raised exception

Copy link
Copy Markdown
Contributor

@aneojgurhem aneojgurhem Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but this can be raised in other cases too. https://learn.microsoft.com/en-us/dotnet/api/system.io.ioexception?view=net-9.0#remarks


return targetFileName;
}
Expand Down