feat: Add module to get a Key from the GCP Project#84
Open
hbitoun-aneo wants to merge 10 commits into
Open
Conversation
Contributor
lemaitre-aneo
left a comment
There was a problem hiding this comment.
This module should behave similarly than the kms module (except for resource creation). In particular, it should support multiple keys per key ring, and have the same output as the kms module.
Contributor
There was a problem hiding this comment.
The documentation should highlight the purpose of the module in the framework of ArmoniK
Contributor
lemaitre-aneo
left a comment
There was a problem hiding this comment.
I am not a big fan of the name of the module. I would prefer to have kms at the beginning of the name.
Here are some name suggestions (in order of personal preference):
kms-getkms-datakms-existingkms-importkms-external
| type = string | ||
| variable "crypto_key_names" { | ||
| description = "The names of the crypto keys to retrieve from the GCP project." | ||
| type = list(string) |
Contributor
There was a problem hiding this comment.
Suggested change
| type = list(string) | |
| type = set(string) |
| @@ -1,4 +1,19 @@ | |||
| output "my_crypto_key_output" { | |||
Contributor
There was a problem hiding this comment.
Suggested change
| output "my_crypto_key_output" { | |
| output "cyprto_keys" { |
Contributor
There was a problem hiding this comment.
There is a missing output compared to to the resource module:
output "crypto_key_ids" {
description = "The Map of the created crypto keys."
value = { for key, value in google_kms_crypto_key.keys : key => value.id }
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.