Skip to content

Conversation

@clydin
Copy link
Member

@clydin clydin commented Dec 19, 2025

Replaces the Protractor-based ng e2e execution with the new Puppeteer executeBrowserTest utility in various build and misc E2E tests.

The following tests were updated:

  • auto-csp
  • worker
  • trusted-types

This migration involves implementing custom checkFn logic to replicate the assertions previously handled by Protractor, such as verifying server-rendered content, console logs, and service worker states.

@clydin clydin added the target: minor This PR is targeted for the next minor release label Dec 19, 2025
@clydin clydin force-pushed the e2e/protractor-convert-3 branch 2 times, most recently from 9cf0b71 to e406340 Compare December 22, 2025 16:14
@clydin clydin force-pushed the e2e/protractor-convert-3 branch 2 times, most recently from 99458ee to 9dba9d2 Compare January 5, 2026 17:25
@clydin clydin marked this pull request as ready for review January 5, 2026 17:47
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 5, 2026
@clydin clydin force-pushed the e2e/protractor-convert-3 branch from 9dba9d2 to 4ccb849 Compare January 6, 2026 15:57
Replaces the Protractor-based `ng e2e` execution with the new Puppeteer
`executeBrowserTest` utility in various build and misc E2E tests.

The following tests were updated:
- auto-csp
- worker
- trusted-types

This migration involves implementing custom `checkFn` logic to replicate
the assertions previously handled by Protractor, such as verifying
server-rendered content, console logs, and service worker states.
@clydin clydin force-pushed the e2e/protractor-convert-3 branch from 4ccb849 to 85023e3 Compare January 6, 2026 16:12
@hybrist hybrist added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 6, 2026
@hybrist hybrist merged commit 1f30663 into angular:main Jan 6, 2026
35 checks passed
@hybrist
Copy link
Contributor

hybrist commented Jan 6, 2026

This PR was merged into the repository. The changes were merged into the following branches:

@clydin clydin deleted the e2e/protractor-convert-3 branch January 6, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants