Skip to content

refactor(all): migrate to package:web#75

Draft
ahmednfwela wants to merge 6 commits into
angulardart-community:masterfrom
ahmednfwela:feat/migrate-to-package-web
Draft

refactor(all): migrate to package:web#75
ahmednfwela wants to merge 6 commits into
angulardart-community:masterfrom
ahmednfwela:feat/migrate-to-package-web

Conversation

@ahmednfwela

Copy link
Copy Markdown

No description provided.

@GZGavinZhao GZGavinZhao added the enhancement New feature or request label Jun 14, 2024
Signed-off-by: Gavin Zhao <git@gzgz.dev>
Signed-off-by: Gavin Zhao <git@gzgz.dev>
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@GZGavinZhao

Copy link
Copy Markdown

Current blockers, working on them one by one:

  • JSTestability needs to be migrated to staticInterop and extension types. (Mostly done, tests need to be updated)
  • Don't use tear-offs for extension methods. Not difficult to do, just annoying because we use them all over the place in tests for convenience.
  • Functions that are wrapped with toJS need to have more explicit types that follow the interop rules. This is actually a good thing because we'll then have stricter type guarantees.
  • It seems like ElementRef needs to be eliminated. (this may warrant its own issue?)

Signed-off-by: Gavin Zhao <git@gzgz.dev>
Signed-off-by: Gavin Zhao <git@gzgz.dev>
parsed.domEventName,
(event) {
(Event event) {
if (event is KeyboardEvent && parsed.matches(event)) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be event.isA<KeyboardEvent>().

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isA() requires to bump SDK to 3.4.0

@GZGavinZhao GZGavinZhao changed the title feat: migrate to package:web refactor(all): migrate to package:web Jun 17, 2024
@ykmnkmi

ykmnkmi commented Feb 10, 2025

Copy link
Copy Markdown

Any news?

@dukefirehawk

Copy link
Copy Markdown

Is this migration work still going on?

@GZGavinZhao

Copy link
Copy Markdown

Unfortunately not for me as I don't have the time for this.

@ykmnkmi

ykmnkmi commented Mar 27, 2025

Copy link
Copy Markdown

@GZGavinZhao I can push this later.

@GZGavinZhao

Copy link
Copy Markdown

@ykmnkmi Thanks!

@ykmnkmi

ykmnkmi commented Apr 16, 2025

Copy link
Copy Markdown

@GZGavinZhao as new PR?

@GZGavinZhao

Copy link
Copy Markdown

@ykmnkmi That sounds good!

@ykmnkmi

ykmnkmi commented Apr 21, 2025

Copy link
Copy Markdown

@GZGavinZhao working on here.

@insinfo

insinfo commented Nov 18, 2025

Copy link
Copy Markdown

@GZGavinZhao @ykmnkmi Could you publish the ngdart 8.0.0-dev.4 version as ngdart 8.0.0 so that you can later publish version 9 migrated to package:web? I have many of my applications that directly depend on version https://pub.dev/packages/ngdart/versions/8.0.0-dev.4, which in turn depends on dart:html. In fact, I haven't migrated anything to the package:web package yet, although I should migrate something sometime next year.

@ykmnkmi

ykmnkmi commented Nov 18, 2025

Copy link
Copy Markdown

@insinfo I do not publish it. I found some problems with DOM properties. I will look into it later. +1 for web migration in next version.

@insinfo

insinfo commented Feb 25, 2026

Copy link
Copy Markdown

@ykmnkmi I would appreciate it if you could at least release dart: 8.0.0-dev.4 as ngdart: 8.0.0 so I can migrate my projects to ngdart: 8.0.0, as currently all my projects depend on version 8.0.0-dev.4.

@ykmnkmi

ykmnkmi commented Feb 25, 2026

Copy link
Copy Markdown

@insinfo I don't have pub access. @GZGavinZhao.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants