chore: rewrite hero/about copy, add favicon and polish portfolio#6
Merged
Conversation
Copy: - rewrite hero description to a concrete one-liner - replace generic "passionate about clean code" text in About - soften typewriter roles (drop "Expert") - update years experience: 3+ -> 4+ - new contact subtitle Favicon and head: - generate 32, 64, 192, 512 PNGs and 180 apple-touch-icon from avatar - add manifest.json, robots.txt, sitemap.xml - set page title, theme-color and meta description - drop unused boxicons and unicons CDN <link>s Audit fixes: - footer copyright year now uses Date.getFullYear() - move EmailJS service/template/public key to REACT_APP_* env vars with .env.example checked in and .env gitignored - pass missing subject field to EmailJS template params - add aria-label to certificate and service modal close buttons - bump caniuse-lite via update-browserslist-db - rewrite README with stack, env setup, build/deploy and image pipeline - remove deploy.txt scratchpad scripts/generate-favicon.js regenerates the favicon set from src/assets/avatar.jpg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
REACT_APP_*env vars; commit.env.example, gitignore.envdeploy.txtscratchpadCopy changes
Head and PWA
public/index.html: set title (Vũ Xuân Anh — Full Stack Developer), theme-color, meta description, favicon links and apple-touch-iconpublic/manifest.json(new): name, icons, standalone display, theme/background colorspublic/robots.txt,public/sitemap.xml(new)boxiconsanduniconsCDN<link>s (render-blocking, no usage)Environment / config
REACT_APP_EMAILJS_SERVICE_ID,REACT_APP_EMAILJS_TEMPLATE_ID,REACT_APP_EMAILJS_PUBLIC_KEYfrom env, with a friendly error if missing.env.examplechecked in;.envadded to.gitignorecaniuse-liteupdated viaupdate-browserslist-dbOther
Footer.tsx:currentYearnow usesnew Date().getFullYear()Certificate.tsxandServices.tsx: aria-label added to modal closeIconButtonsREADME.mdrewritten: stack, layout, local dev, env vars, build/deploy, image pipeline, structuredeploy.txtremovedscripts/generate-favicon.js(new): regenerates the favicon set fromsrc/assets/avatar.jpgTest plan
npm run dev— favicon shows the avatar in the browser tabmanifest.json(DevTools > Application > Manifest)npm run buildsucceeds