MIG-5: the reference pipeline — three sources, one downstream half - #232
Merged
Merged
Conversation
MIG-5's cross-repository test and boundary consolidation's BND-1. A .vrma (through usdVrmaFileFormat), a BVH export and a recorded session (as usd-motion-plugins' motion_convert and motion_record wrote them) are baked onto Seed-san.vrm through one motion_retarget argument list, and the test asserts the half after the clip is the same code: loaded plugins and modules differ by the first arrow's importer alone, the output layers share one shape and joint order, and every bake passes one set of motion checks (rotation away from rest, hips travel, unbindable bones named, nothing outside the humanoid moves, scales authored). workspace_reference_pipeline_local runs the same checks over data that cannot be committed (USDVRM_LOCAL_AVATAR, USDVRM_LOCAL_VRMA_DIR, optionally keeping bakes in USDVRM_LOCAL_OUTPUT_DIR) and is Skipped without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A bake references its avatar by a path relative to itself, so a copy out of the temporary directory pointed at a .vrm that is not there and opened in usdview with no model. Found opening the first kept bake. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MIG-5's cross-repository test ("VRMA →
MotionClip→ a target VRM runs somewhere by default"), which is also boundary consolidation's BND-1 ("one reference pipeline, proved once for every category").What it runs
workspace_reference_pipelinebakes three source categories ontoSeed-san.vrm:.vrmausdVrmaFileFormatcanonical_walk.vrmausd-motion-plugins'motion_converttests/motion/fixtures/mocopi-mobile-arm-raise-turn.usda(committed output)usd-motion-plugins'motion_recordtools/motionRetarget/tests/fixtures/recorded_session_clip.usda(committed output)All three go through one
motion_retargetargument list that differs only in--animation.What it asserts: the downstream half is the same code
--load-report's plugins and modules differ across sources by the first arrow's plugin alone. Measured: a.vrmaadds exactlyUsdVrmaFileFormat/libUsdVrmaFileFormat.dll, and the other two load identical sets.Mutations (each fails where it should; unmutated passes)
--root-motion ignorefor the trace source only--humanoid-mapfor the BVH source only.vrma--animation-name Otherfor the trace source onlyLocal, non-redistributable data
workspace_reference_pipeline_localruns the same checks over an avatar and.vrmafiles that cannot be committed. It reads them fromUSDVRM_LOCAL_AVATARandUSDVRM_LOCAL_VRMA_DIR, andUSDVRM_LOCAL_OUTPUT_DIRoptionally keeps each bake. Without them it reports Skipped (SKIP_RETURN_CODE 77). On 2026-09-24 it passed overAliciaSolid.vrm(VRM 0.x) and the seven VRM Animation MotionPack clips, with the BVH export and the recorded session beside them (9/9). Neither dataset may be redistributed: AliciaSolid isredistributionAllowed: falsein the corpus manifest, and the MotionPack terms forbid redistribution in extractable form.Verification (Windows, local)
ost test: 41 passed, 1 skipped (the local test, without its variables).ost test --filter workspace_reference_pipelinewith the local variables set: both pass.check_docs.pyOK;check_cmake_boundaries.pyholds.Docs: CHANGELOG
[Unreleased], MIG-5 item 4 ✅ (track and current.md), BND-1 ✅. MIG-5's last item, the release-artifact proof, is the next release's dry run.🤖 Generated with Claude Code