[fix/feature] add nrmc run flag for OMP_TOOL_LIBRARIES#109
Merged
Conversation
Add a command line option for nrmc run to append a set of libraries to the OMP_TOOL_LIBRARIES. This envvar is the new standard recommended way of loading tools in OpenMP. Improve on nrm_string_join to help with this.
Github is retiring the ubuntu 20.04 image, and we can work without it.
Fix vjoin logic to correctly deal with empty strings, refactor the nrmc cmd_run getenv/setenv logic to something a bit cleaner, with less extra vars. Make sure we destroy all strings.
Contributor
Author
|
Fixes #108 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a command line option for nrmc run to append a set of libraries to the OMP_TOOL_LIBRARIES. This envvar is the new standard recommended way of loading tools in OpenMP.
Improve on nrm_string_join to help with this.