docs: point the fork procedures at the current pin, drop the skew note - #39
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #38, from a review of it. Comments and docs only — no code, no dependency change.
The fork skew is gone.
martin-tightcutwas fast-forwarded toffaecd70(the 8.0.1-based rev #38 pins), so theNOTE (2026-08-30)block inCargo.tomldescribes a state that no longer exists. The pre-8.0.1 base is kept on the fork asmartin-tightcut-8.0.0-base, so nothing was destroyed, andmartin-tightcut-rebasedstill exists too.What replaces the note is the failure mode that is durable: a
../bgs-forkcheckout older than the pinned rev no longer satisfiesversion = "8.0.1", and cargo does not error on that — it printswarning: patch ... was not used in the crate graphand resolves the real crate from crates.io instead, after which the build dies on missingCloudSettingsfields (bulge,swarm,deform_mode,morph_stagger,additive) with the cause scrolled off-screen. Reproduced with real cargo.OPTIMIZATION-BACKLOG.mdnamed a stale SHA as a gate. The fork-shader procedure said to confirm the local checkout matches "the pinned commit (Cargo.lockrevf94855a4)" before editing and pushingmartin-tightcut. That was the pre-8.0.1 rev — the only literal SHA left in the tree, and an instruction rather than a description. Following it after #38 would have confirmed the old base as correct and pushed shader edits from it, reverting the rebase. It now points at whateverCargo.locknames, so it cannot go stale on the next bump.DESIGN.mdoverstated what 8.0.1 contains. It said the §11lazy_type_alias→checked_type_aliasesrename "shipped in 8.0.1". Upstream order is #236 (the version bump) and then #237 (the rename) on top of it, and 8.0.1 was published to crates.io on 2026-06-25, before #237 landed. The registry 8.0.1 still gates onlazy_type_aliasand fails E0557 on the pinned nightly, so the fork patch stays load-bearing. #38's own CHANGELOG entry already had this right.🤖 Generated with Claude Code
https://claude.ai/code/session_01Bw2Ct6EsS5eag5VScjgk2j