Skip to content

docs: point the fork procedures at the current pin, drop the skew note - #39

Merged
annejan merged 3 commits into
mainfrom
docs/fork-pin-followup
Aug 30, 2026
Merged

annejan merged 3 commits into
mainfrom
docs/fork-pin-followup

Conversation

@annejan

@annejan annejan commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Follow-up to #38, from a review of it. Comments and docs only — no code, no dependency change.

The fork skew is gone. martin-tightcut was fast-forwarded to ffaecd70 (the 8.0.1-based rev #38 pins), so the NOTE (2026-08-30) block in Cargo.toml describes a state that no longer exists. The pre-8.0.1 base is kept on the fork as martin-tightcut-8.0.0-base, so nothing was destroyed, and martin-tightcut-rebased still exists too.

What replaces the note is the failure mode that is durable: a ../bgs-fork checkout older than the pinned rev no longer satisfies version = "8.0.1", and cargo does not error on that — it prints warning: patch ... was not used in the crate graph and resolves the real crate from crates.io instead, after which the build dies on missing CloudSettings fields (bulge, swarm, deform_mode, morph_stagger, additive) with the cause scrolled off-screen. Reproduced with real cargo.

OPTIMIZATION-BACKLOG.md named a stale SHA as a gate. The fork-shader procedure said to confirm the local checkout matches "the pinned commit (Cargo.lock rev f94855a4)" before editing and pushing martin-tightcut. That was the pre-8.0.1 rev — the only literal SHA left in the tree, and an instruction rather than a description. Following it after #38 would have confirmed the old base as correct and pushed shader edits from it, reverting the rebase. It now points at whatever Cargo.lock names, so it cannot go stale on the next bump.

DESIGN.md overstated what 8.0.1 contains. It said the §11 lazy_type_aliaschecked_type_aliases rename "shipped in 8.0.1". Upstream order is #236 (the version bump) and then #237 (the rename) on top of it, and 8.0.1 was published to crates.io on 2026-06-25, before #237 landed. The registry 8.0.1 still gates on lazy_type_alias and fails E0557 on the pinned nightly, so the fork patch stays load-bearing. #38's own CHANGELOG entry already had this right.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Bw2Ct6EsS5eag5VScjgk2j

@annejan
annejan enabled auto-merge (squash) August 30, 2026 19:58
@annejan
annejan merged commit 080c417 into main Aug 30, 2026
19 checks passed
@annejan
annejan deleted the docs/fork-pin-followup branch August 30, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant