Skip to content

fix: Multiple asking for credentials while deploying #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gescheit merged 1 commit into from
Aug 6, 2026
Merged

fix: Multiple asking for credentials while deploying #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/gnetcli_adapter/gnetcli_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,7 @@ async def _bulk_deploy(
args: DeployOptions,
progress_bar: ProgressBar | None = None,
) -> DeployResult:
dev_credentials = self.conf.make_dev_credentials()
if progress_bar:
for host, cmds in deploy_cmds.items():
progress_bar.set_progress(host.fqdn, 0, len(cmds))
Expand All @@ -387,7 +388,7 @@ async def _bulk_deploy(
else:
result = await gather_with_concurrency(
max_parallel,
*[self.deploy(api, device, cmds, args, progress_bar) for device, cmds in deploy_items],
*[self.deploy(api, device, cmds, args, progress_bar, dev_credentials) for device, cmds in deploy_items],
)
res = DeployResult(hostnames=[], results={}, durations={}, original_states={})
res.add_results(results={dev.fqdn: dev_res for (dev, _), dev_res in zip(deploy_items, result)})
Expand Down Expand Up @@ -460,11 +461,12 @@ async def deploy(
cmds: CommandList,
args: DeployOptions,
progress_bar: ProgressBar | None = None,
dev_credentials: Credentials | None = None,
) -> Exception | None:
gnetcli_device = breed_to_device.get(device.breed, device.breed)
ip = get_device_ip(device)
host_params = HostParams(
credentials=self.conf.make_dev_credentials(),
credentials=dev_credentials,
device=gnetcli_device,
ip=ip,
)
Expand Down
Loading