Fixed an issue where microsoft.ad.domain module did not error correctly

[AllRWeak]

SUMMARY

This pull requests fixes an issue where the microsoft.ad.domain module leaves a host in a limbo state if it finds that the forest already exists but the host itself is not a domain controller. The issue can occur when more then 1 domain controller exists in a forest and a user tries the re-install one with the microsoft.ad.domain module. When trying to do it manually the domain controller will give an error that the forest or netbios name already exists. With this fix the microsoft.ad.domain module will give the same error.

Fixes #177

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

microsoft.ad.domain module

ADDITIONAL INFORMATION

More info is described in the issue - #177

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1a0acb7d1d09474f9f3b8bde317a12fb

✔️ ansible-galaxy-importer SUCCESS in 4m 30s
✔️ build-ansible-collection SUCCESS in 5m 47s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2b91fec73dbc4ca5b048d8db69c5bef6

✔️ ansible-galaxy-importer SUCCESS in 2m 54s
✔️ build-ansible-collection SUCCESS in 5m 18s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7d51ce2d682440eeb868cfeb6be02242

✔️ ansible-galaxy-importer SUCCESS in 2m 56s
✔️ build-ansible-collection SUCCESS in 5m 58s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7959bbedd6024ef39d4ab5f3edb402c0

✔️ ansible-galaxy-importer SUCCESS in 3m 47s
✔️ build-ansible-collection SUCCESS in 5m 47s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/76b202537a0f42d79a25041e93e77d20

✔️ ansible-galaxy-importer SUCCESS in 3m 52s
✔️ build-ansible-collection SUCCESS in 5m 50s

[centosinfra-prod-github-app]

Build failed.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/ansible/buildset/ff5ac931a76f495692198c4a7e0a6a6c

❌ ansible-galaxy-importer RETRY_LIMIT Host unreachable in 6m 48s
✔️ build-ansible-collection SUCCESS in 3m 29s

[centosinfra-prod-github-app]

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/ansible/buildset/90cabdcbb71348e1a7d3cbf27c1a0514

✔️ ansible-galaxy-importer SUCCESS in 8m 06s
✔️ build-ansible-collection SUCCESS in 3m 20s

[jborean93]

If the host is a DC but not for the forest requested then I would have through that this should fail rather than just skip the task.

[AllRWeak]

With this PR this does fail with the correct message:

    msg: |-
        Failed to run Install-ADDSForest, DCPromo exited with 45: The name example.com is already in use on this network. Specify a name that is not in use.
    reboot_required: false

without the PR just reports the task as changed but not actually having configured the domain controller.

[AllRWeak]

The logic here is that the the previous variable $forestContext detects that the forest exists but if the host is not promoted to a domain controller then that cannot happen. That's why the extra check if (-not $forest -or -not $host_is_dc) {... in that case it'll still try and promote the host to a DC but will fail with an error message provided by the Install-ADDSForest command instead of just moving on and failing later with other modules.

[jborean93]

Ah I see sorry it's an -or and not -and check so the code here runs when either $forest is falsey or if Get-ADDomainController "failed".

I'm not sure if Get-ADDomainController is a good check here as it means the host needs to have the ActiveDirectory module is installed which isn't guaranteed here. An alternative could be through WMI/CIM

$os = Get-CimInstance -ClassName Win32_OperatingSystem -Property ProductType
$isDC = $os.ProductType -eq 2

[AllRWeak]

Yes a valid point. I updated the PR to use Get-CimInstance instead.

[AllRWeak]

Is it fine to be pulled now?

[centosinfra-prod-github-app]

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/ansible/buildset/9e468385b96546d489181bae790a6fc4

✔️ ansible-galaxy-importer SUCCESS in 4m 15s
✔️ build-ansible-collection SUCCESS in 5m 41s