ci: Add external postgresql logs#340
Conversation
📝 WalkthroughWalkthroughBoth CI and PR workflow files are updated to conditionally fetch database logs based on the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
83869f4 to
2ebede0
Compare
Only the internal managed postgresql pod get logs gathered at the end of the CI run. When using an external database (like one of the CI scenario) then those logs aren't gathered. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2ebede0 to
3415718
Compare
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 126-128: The eval command in the "Get logs" step is currently not
tolerant to failure, so if eval $(minikube -p minikube docker-env) fails it
aborts log collection; change that invocation to be best-effort (e.g., make the
eval non-fatal by appending a failure-tolerant operator such as "|| true" or
otherwise ensuring the shell does not exit on failure) so the subsequent docker
logs postgresql || true still runs; apply the same change to the matching line
in .github/workflows/pr.yml where eval $(minikube -p minikube docker-env)
appears.
In @.github/workflows/pr.yml:
- Around line 120-122: The unguarded eval $(minikube -p minikube docker-env) can
fail and abort the always() log-collection step; modify the step to guard that
command (e.g., append "|| true" or otherwise tolerate failure) so the eval
cannot cause the job to exit before running docker logs postgresql --tail 1000;
locate the eval invocation and update it to be a no-fail invocation (eval
$(minikube -p minikube docker-env) || true) so docker logs postgresql still
runs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 397ce906-b9e5-4813-bcd7-b1d677f6197e
📒 Files selected for processing (2)
.github/workflows/ci.yml.github/workflows/pr.yml



Only the internal managed postgresql pod get logs gathered at the end of the CI run.
When using an external database (like one of the CI scenario) then those logs aren't gathered.
Summary by CodeRabbit