Add CST_570004_WW cassette AC support - #129
Open
BluSyn wants to merge 1 commit into
Open
Conversation
Map cassette model CST_570004_WW to the RAC TLV handler and accept 0xA7 fromDevice framing in tlv_device (required for this platform). Explicitly power on with non-off climate mode writes; unlock autodry, air purify, energy save, timers, and swing from state tags when caps bits are missing; expose 0x336 humidity as tenths of a percent. Decode 0xA7 in packet-codec; autodry is a writable optimistic switch.
Owner
|
Thank you for the PR. I've just returned from vacation and I'm slowly working through the PR & issue backlog. I'd appreciate your patience :) |
|
|
||
| /** | ||
| * Optional features are unlocked by caps feature-words when present. | ||
| * Some models (e.g. CST_570004_WW cassette) omit or use different caps bits |
Collaborator
There was a problem hiding this comment.
I don't think we should enable features supported by the official ThinQ API and app just based on presence of particular tag - for example many (all?) RAC_056905_WW models have air purifier tag but only some models actually have an air purifier module inside.
Usually these features can be auto-detected from caps - that's how app knows whether to display particular feature widget and so should we.
Most likely CST_570004_WW simply has different cap bits than RAC_056905_WW - what does its model JSON file say?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map cassette model CST_570004_WW to the RAC TLV handler and accept 0xA7 fromDevice framing in tlv_device (required for this platform). Explicitly power on with non-off climate mode writes; unlock autodry, air purify, energy save, timers, and swing from state tags when caps bits are missing; expose 0x336 humidity sensor. Decode 0xA7 in packet-codec; autodry is a writable switch.
LG AC Cassette models tested:
ARNU36GTNA4andARNU18GTQA4. Internal modelCST_570004_WWreported. These models don't have built-in wifi; was connected using wifi module accessoryPWFMDD200through wifi module port on main board.This has one unique feature: humidity reporting. All other features are generic to other devices as well.
This did require some refactoring due to difference in behavior vs base device. Tested base device on other compatible units without issue; no regressions found.