rethink-setup provisioning fixes for RTK_RTL8711am module - #131
Open
BluSyn wants to merge 1 commit into
Open
Conversation
Improve rethink-setup setApInfo with a two-pass scan refine (frequency / security), multiprofile and legacy bssid fields, credential length logging, and delayed releaseDev so picky RTK_RTL8711am firmwares join home Wi-Fi. Allow CBC-SHA cipher suites (SECLEVEL=0, min TLS 1.0) on device HTTPS/MQTTS listeners so older CLIP clients can complete /route when terminating TLS on Node. Note: nginx reverse proxies need the same ciphers if they terminate 443.
Owner
|
Thank you for the PR. I've just returned from vacation and I'm slowly working through the PR & issue backlog. I'd appreciate your patience :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May be hard to merge this since it touches important setup paths, but hoping it's useful for someone else.
This resolved 2 specific issues:
rethink-setup.tswould succeed to provision device, but device doesn't fully join wifi after completion (this took lots of debugging to resolve, this PR adds lots of extra debugging output during setup as a result).Devices this resolved in testing:
Both devices have
RTK_RTL8711ammodules, so likely hardware related. Combined these 2 fixes into one PR since they are likely related to same hardware support.Specific changes:
Improves rethink-setup setApInfo with a two-pass scan refine (frequency / security), multiprofile and legacy bssid fields, credential length logging, and delayed releaseDev. (delayed releaseDev is most likely the change that actually fixed the problem)
Allow CBC-SHA cipher suites (SECLEVEL=0, min TLS 1.0) on device HTTPS/MQTTS listeners so older CLIP clients can complete /route request. (Note: nginx reverse proxies need the same ciphers if used to terminate 443)