fix(x-sdk): release XStream reader on early exit - #159
Merged
Conversation
Member
Author
Review:✅ 修复合理,建议合并
四条验收标准都满足。三个测试分别覆盖提前 break、消费者抛错(且断言 cancel 失败时原始错误仍被保留)、正常完整消费,覆盖面完整。 无阻塞问题。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
028b7436a23f0433a635de0dfa3777dbf56515ff)💡 Background and Solution
XStreamacquired a reader for its async iterator without releasing it when a consumer exited afor await...ofloop early. This left the stream locked and allowed the underlying source to continue buffering.This change:
try/finallyand distinguishes normal completion from early exitbreak,return, or consumer errorsVerification:
vp test packages/x-sdk/src/x-stream/__tests__/index.test.ts— 3 passedvp test— 46 files, 445 tests passedvp check packages/x-sdk/src/x-stream/index.ts packages/x-sdk/src/x-stream/__tests__/index.test.ts— passedvp checkformatting passed; lint/type checking is currently blocked by 43 unrelated existing errors outside this change📝 Change Log