fix(thought-chain): make line prop effective - #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English template / 英文模板
🤔 本次变更属于 ...
🔗 相关 Issue
暂无。
💡 背景与方案
ThoughtChain的line属性没有完整生效:布尔值false被解析为无连线状态后,没有生成对应的样式类,而基础伪元素仍会绘制实线。本次修复对齐上游
x-ant-design的实现方式:line=true的实线状态。solid、dashed、dotted字符串值生成对应的节点图标样式类。line=false增加node-icon-none样式,明确隐藏连接线。:last-of-type隐藏最后一个节点的连接线。line取值的单元测试。验证结果:
vp check:0 errors(仓库现有 8 条无关 warning)vp test:45 个测试文件、447 个测试通过vp run --filter @antdv-next/x build:通过📝 变更日志
lineprop.line属性的问题。