fix(docs): token color chunk popover preview sync (#1994) - #164
Merged
Conversation
- Use --ant-tooltip-arrow-background-color for the popover arrow - Add destroyOnHidden to remove preview DOM on close - Drop redundant transparent root background override
Member
Author
Review:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
Syncing upstream PR ant-design/x#1994 to fix the Token color-chunk Popover preview.
The docs color-chunk component read a non-existent
--antd-arrow-background-coloron its root, while the current antdv-next Popover actually reads--ant-tooltip-arrow-background-color. This made the popover arrow default to the theme arrow color instead of the actual Token color.Changes:
--ant-tooltip-arrow-background-colorfor the Popover arrow so it matches the Token color.destroyOnHiddenso the preview DOM is removed after closing.📝 Change Log