Repository navigation
Fix GCS error handling for bounded artifact reads - #1020
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small immutable artifact GETs cap successful response bodies at the expected artifact size. GCS previously applied that same cap to HTTP error envelopes, turning missing, denied, or unavailable objects into
ResponseTooLargeand then an artifact integrity error.Give GCS a separate 4 KiB error-response allowance while preserving the successful response ceiling. Add a real HTTP regression covering 404, 403, and 503 responses, oversized error envelopes, and oversized successful bodies.
Validation: Zig 0.17 objectstore unit suite passed (cloud integration tests remain opt-in). The new regression fails without the fix with
expected error.FileNotFound, found error.ResponseTooLarge.git diff --checkpassed.Follow-up to #1019.