-
Notifications
You must be signed in to change notification settings - Fork 0
Fix LanceDB flat schema metadata extraction and column width limits #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5aecdae
fix: LanceDB flat schema metadata extraction and column width limits
anthonypdawson 88b722d
docs: update CHANGELOG for v0.8.4
anthonypdawson 081fa9a
ci: add PR checks for tests and linting
anthonypdawson 3da7b67
chore: finalize v0.8.4 release prep
anthonypdawson 380ceb7
chore: bump __version__ to 0.8.4 in __init__.py
anthonypdawson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| name: Lint | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - master | ||
| - main | ||
| push: | ||
| branches: | ||
| - master | ||
| - main | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| lint: | ||
| name: Lint with Ruff | ||
| runs-on: ubuntu-latest | ||
| continue-on-error: true # Advisory only - won't block PRs | ||
|
|
||
| steps: | ||
| - name: Check out repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: "3.12" | ||
|
|
||
| - name: Install Ruff | ||
| run: pip install ruff | ||
|
|
||
| - name: Run Ruff linter | ||
| run: ruff check src/ tests/ --output-format=github | ||
|
|
||
| - name: Run Ruff formatter check | ||
| run: ruff format --check src/ tests/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,22 @@ | ||
| # Release Notes (0.8.3) — June 21, 2026 | ||
| # Release Notes (0.8.4) — June 23, 2026 | ||
|
|
||
| Content column detection improvements and local embedding support. | ||
| Critical LanceDB metadata extraction fixes and column rendering improvements. | ||
|
|
||
| ## Features | ||
| ## Bug Fixes | ||
|
|
||
| - **Dynamic content column detection**: Automatically detects the best content column for each collection based on schema analysis (text/string fields, common naming patterns). Manual override support with persistence across sessions. | ||
| - **Ollama embedding integration**: Local embedding generation via Ollama HTTP API for environments where HuggingFace is blocked or unavailable. | ||
| - **LanceDB flat schema metadata extraction**: Fixed metadata display for LanceDB databases with flat schemas (e.g., Contextus) where metadata is stored as individual columns rather than nested in a 'metadata' column | ||
| - **Duplicate document column**: Prevented content column from appearing twice in data browser (once as content, once as metadata) | ||
| - **Column width limits**: Added 600px max-width constraint to table columns to prevent excessive width from breaking UI | ||
|
|
||
| ## Improvements | ||
|
|
||
| - Content column configuration UI shows both auto-detected recommendation and currently active column | ||
| - Settings persistence for content column overrides per collection | ||
| - Fixed LanceDB schema detection to use PyArrow schema instead of pandas DataFrame conversion (performance improvement) | ||
| - Fixed threading deadlock in content column detection (switched from Lock to RLock) | ||
| - Platform-specific monospace fonts in UI dialogs (Menlo on macOS, Consolas on Windows) | ||
| - LanceDB connection now extracts metadata from PyArrow schema first for better performance | ||
| - Content column (e.g., "document") is automatically detected and excluded from metadata fields | ||
| - Backward compatibility maintained with nested 'metadata' column format | ||
|
|
||
| ## Bug Fixes | ||
| ## Testing | ||
|
|
||
| - Fixed LanceDB metadata array length mismatch in search results | ||
| - Fixed QThread leak in embedding configuration dialog | ||
| - Fixed content column cache poisoning when schema unavailable | ||
| - Added comprehensive tests for flat schema metadata extraction | ||
| - CI workflow now runs unit tests on all pull requests | ||
|
|
||
| --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.