server: guard disk KV cache with CRC32C#146
Open
Ghatage wants to merge 1 commit into
Open
Conversation
Benefit: bad disk snapshots are rejected before session state is restored, while existing v1 caches stay readable. Write new KV cache files as v2 with CRC32C for header metadata, rendered text, DS4 payload, and tool map. Keep v1 reads and touches intact, and recompute v2 CRCs when hit counts or tool maps are rewritten. Reject corrupt v2 entries during load and same-text compatibility checks. A broken cache file is unlinked and replaced by a fresh write. Correctness: git diff --check; CPU-built ./ds4_test --server. Correctness: non-CPU tests/ds4_test.c object compile.
Ghatage
force-pushed
the
crc32c-disk-kv-cache
branch
from
0bfe4be to
0025dd3
Compare
|
Did something in DS4 write out a corrupt KV cache file or is this preventative in case that happens in the future? |
Contributor
Author
|
ds4 did not corrupt anything... this is purely preventative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bad disk snapshots are rejected before session state is restored, while existing v1 caches stay readable.
Write new KV cache files as v2 with CRC32C for header metadata, rendered text, DS4 payload, and tool map. Keep v1 reads and touches intact, and recompute v2 CRCs when hit counts or tool maps are rewritten.
Reject corrupt v2 entries during load and same-text compatibility checks. A broken cache file is unlinked and replaced by a fresh write.
Correctness: git diff --check; CPU-built ./ds4_test --server.
Correctness: non-CPU tests/ds4_test.c object compile.