Report progress while the resident video VAE decodes - #35
Open
AlexanderIstomin wants to merge 1 commit into
Open
Report progress while the resident video VAE decodes#35AlexanderIstomin wants to merge 1 commit into
AlexanderIstomin wants to merge 1 commit into
Conversation
The resident decoder reports progress while loading its 36 blocks and then decodes in silence, so a caller's progress display holds its last value for the whole decode. That is not a small tail: on a still, where one frame is kept from a decoded chunk, the decode is a quarter of the entire generation, and it reads as a hang. run_resident_tile now reports each block it runs, and the decoder gained an optional progress sink for that phase, so callers can label it separately from the load. Decoders without a sink decode exactly as before. Spatial tiles each run the full block stack, so a raw per-tile count would restart the reported figure once per tile. The decoder tracks its place in the tiling and forwards position in the whole decode instead: a four-tile canvas advances 1/144 to 144/144 rather than counting to 36 four times.
LachlanStuart
added a commit
to LachlanStuart/h3.c
that referenced
this pull request
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resident decoder reports progress while loading its 36 blocks, then
decodes in silence. A caller's progress display therefore holds its last
value for the entire decode.
That is not a small tail. On a still — where one frame is kept from a
decoded chunk — the decode is about a quarter of the whole generation.
In our app it presented as the progress bar sitting at 100% for two to
three minutes, and users reasonably read it as a hang.
The change
run_resident_tilereports each block it runs, andh3_video_vae_decodergained an optional progress sink so callers canlabel the decode separately from the load. A decoder without a sink
decodes exactly as before, so this is additive:
h3_video_vae_decodeand every existing caller are unaffected.
Spatial tiles each run the full block stack, so a raw per-tile count
would restart the reported figure once per tile. The decoder tracks its
place in the tiling and forwards position in the whole decode instead —
a four-tile canvas advances 1/144 to 144/144 rather than counting to 36
four times, so the figure only ever moves forward.
Measured on an M1 Pro: a 352-square still decodes in four tiles, and the
reported sequence is monotonic across all of them.